Closed Bug 499596 Opened 16 years ago Closed 16 years ago

"]" in filename breaks "open containing folder" inline button in completed DCC message

Categories

(Other Applications Graveyard :: ChatZilla, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glenjamin+bmo, Assigned: Gijs)

Details

(Whiteboard: [cz-0.9.86])

Attachments

(1 file)

2.25 KB, patch
bugzilla-mozilla-20000923
: review+
Details | Diff | Splinter Review
As summary said - haven't looked into it yet. Fix will likely either be tidying up the regex/munger, or escaping the filename more rigourously before creating the button.
Attached patch PatchSplinter Review
There were some other issues. Anyway, the code uses a file:/// URL now.
Assignee: rginda → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #404292 - Flags: review?(silver)
Attachment #404292 - Flags: review?(silver) → review+
Checking in mozilla/extensions/irc/xul/content/commands.js; /cvsroot/mozilla/extensions/irc/xul/content/commands.js,v <-- commands.js new revision: 1.170; previous revision: 1.169 done Checking in mozilla/extensions/irc/xul/content/handlers.js; /cvsroot/mozilla/extensions/irc/xul/content/handlers.js,v <-- handlers.js new revision: 1.196; previous revision: 1.195 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.86]
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: