499608 - Leak nsSVGRenderingObserverList with <svg:filter>

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase

This testcase might just be a reduction of layout/reftests/svg/filters/filter-patterned-rect-01.svg.

valgrind 
    --leak-check=full
    --auto-run-dsymutil=yes
    --track-origins=yes 
    ~/central/debug-obj/dist/MinefieldDebug.app/Contents/MacOS/firefox-bin 
    -P vgrind c1.html 

164 (32 direct, 132 indirect) bytes in 1 blocks are definitely lost in loss record 1,241 of 1,915
   at 0x12B7F: operator new(unsigned long) (vg_replace_malloc.c:218)
   by 0x222E8D29: nsSVGEffects::AddRenderingObserver(nsIFrame*, nsSVGRenderingObserver*) (nsSVGEffects.cpp:436)
   by 0x222E8F85: nsSVGRenderingObserver::GetReferencedFrame() (nsSVGEffects.cpp:97)
   by 0x222E8FB0: nsSVGRenderingObserver::GetReferencedFrame(nsIAtom*, int*) (nsSVGEffects.cpp:108)
   by 0x222E90D9: nsSVGFilterProperty::GetFilterFrame() (nsSVGEffects.cpp:192)
   by 0x222FFAE2: nsSVGEffects::EffectProperties::GetFilterFrame(int*) (nsSVGEffects.h:234)
   by 0x2231155D: nsSVGUtils::PaintFrameWithEffects(nsSVGRenderState*, nsIntRect const*, nsIFrame*) (nsSVGUtils.cpp:899)
   by 0x222E749A: nsSVGDisplayContainerFrame::PaintSVG(nsSVGRenderState*, nsIntRect const*) (nsSVGContainerFrame.cpp:172)
   by 0x22311919: nsSVGUtils::PaintFrameWithEffects(nsSVGRenderState*, nsIntRect const*, nsIFrame*) (nsSVGUtils.cpp:970)
   by 0x2230340B: nsSVGOuterSVGFrame::Paint(nsIRenderingContext&, nsRect const&, nsPoint) (nsSVGOuterSVGFrame.cpp:566)
   by 0x223035EB: nsDisplaySVG::Paint(nsDisplayListBuilder*, nsIRenderingContext*, nsRect const&) (nsSVGOuterSVGFrame.cpp:459)
   by 0x21B26CD2: nsDisplayList::Paint(nsDisplayListBuilder*, nsIRenderingContext*, nsRect const&) const (nsDisplayList.cpp:317)

Comment 1

[Jesse Ruderman]

The patch in bug 499613 provides a way to debug this leak without valgrind, assuming I did it right.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Easy fix

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/59b6f57cd825