User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1) Gecko/20090616 Firefox/3.5 (.NET CLR 3.5.30729) Build Identifier: AvmLog function is used in pcre_compile.cpp to output debug information. AvmLog is defined in namespace avmplus. There is no 'using namespace avmplus' in the code, neither are usage of AvmLog prefixed with 'avmplus::'. Reproducible: Always Steps to Reproduce: 1. Run configure.py to produce the Makefile 2. Edit the Makefile and append 'PCRE_DEBUG' to APP_CPPFLAGS. 3. Compiler crashes on pcre_compile.cpp with the message '/tamarin-redux/pcre/pcre_compile.cpp:6155: error: 'AvmLog' was not declared in this scope'. Actual Results: Build failure.
Created attachment 384389 [details] [diff] [review] Prefix AvmLog usage in pcre_compile.cpp with 'avmplus::'
Attachment #384389 - Flags: review?
There are two ways to solve the build failure: - prefix AvmLog with 'avmplus::' in pcre_compile.cpp - add 'using namespace avmplus;' to pcre_compile.cpp As AvmLog occurs 6 times only in pcre_compile, I picked the 1st solution.
Comment on attachment 384389 [details] [diff] [review] Prefix AvmLog usage in pcre_compile.cpp with 'avmplus::' OK. Let me know if you want me to land it.
Attachment #384389 - Flags: review? → review+
First of all, I would be interested in your opinion if the 1st way is ok, or the 2nd is preferred.
Im fine with the first solution, which is why I approved the patch.
OK, thanks, let's land it!.
Assignee: nobody → lhansen
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
i would like to ask if there is any progress with landing this patch. please, let me know, thanks.
redux changeset: 2064:c876b29c0c66
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.