499671 - pcre debug version build failure, AvmLog is not defined in pcre_compile.cpp

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Zsolt Vilagos]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1) Gecko/20090616 Firefox/3.5 (.NET CLR 3.5.30729)
Build Identifier: 

AvmLog function is used in pcre_compile.cpp to output debug information. AvmLog is defined in namespace avmplus. There is no 'using namespace avmplus' in the code, neither are usage of AvmLog prefixed with 'avmplus::'.

Reproducible: Always

Steps to Reproduce:
1. Run configure.py to produce the Makefile
2. Edit the Makefile and append 'PCRE_DEBUG' to APP_CPPFLAGS.
3. Compiler crashes on pcre_compile.cpp with the message '/tamarin-redux/pcre/pcre_compile.cpp:6155: error: 'AvmLog' was not declared in this scope'.
Actual Results:  
Build failure.

Comment 1

[Zsolt Vilagos]

Attachment: Prefix AvmLog usage in pcre_compile.cpp with 'avmplus::'

Comment 2

[Zsolt Vilagos]

There are two ways to solve the build failure:
  - prefix AvmLog with 'avmplus::' in pcre_compile.cpp
  - add 'using namespace avmplus;' to pcre_compile.cpp

As AvmLog occurs 6 times only in pcre_compile, I picked the 1st solution.

Comment 3

[Lars T Hansen]

Comment on attachment 384389 [details] [diff] [review]
Prefix AvmLog usage in pcre_compile.cpp with 'avmplus::'

OK.  Let me know if you want me to land it.

Comment 4

[Zsolt Vilagos]

First of all, I would be interested in your opinion if the 1st way is ok, or the 2nd is preferred.

Comment 5

[Lars T Hansen]

Im fine with the first solution, which is why I approved the patch.

Comment 6

[Zsolt Vilagos]

OK, thanks, let's land it!.

Comment 7

[Zsolt Vilagos]

i would like to ask if there is any progress with landing this patch. please, let me know, thanks.

Comment 8

[Lars T Hansen]

redux changeset:   2064:c876b29c0c66