Closed
Bug 499675
Opened 16 years ago
Closed 9 years ago
data: scheme should be case-insensitive
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
()
Details
Attachments
(2 files)
|
2.83 KB,
patch
|
Biesinger
:
review-
|
Details | Diff | Splinter Review |
|
1.28 KB,
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
|
Details | Diff | Splinter Review |
Although the IO service asks the data protocol handler to create a DATA: url it fails because the handler only searches for a data: scheme in lower case.
|
Assignee | |
Comment 1•16 years ago
|
||
Odd, this works in 1.9a4, I wonder what changed...
|
|
Assignee | |
Comment 2•16 years ago
|
||
This saves poking holes in the string. (But you call StripWhitespace anyway...)
|
|
Assignee | |
Comment 3•16 years ago
|
||
Comment on attachment 384396 [details] [diff] [review]
String API version
Sigh. No thanks to :bienvenu :-(
Attachment #384396 -
Flags: review? → review?(cbiesinger)
|
|
Assignee | |
Comment 4•16 years ago
|
||
(charset already uses PL_strcasestr)
Attachment #384397 -
Flags: superreview?(cbiesinger)
Attachment #384397 -
Flags: review?(cbiesinger)
|
||
Comment 5•16 years ago
|
||
Comment on attachment 384397 [details] [diff] [review]
Boring version
Can you add a test for this? Should be enough to just call newURI, right?
Attachment #384397 -
Flags: superreview?(cbiesinger)
Attachment #384397 -
Flags: superreview+
Attachment #384397 -
Flags: review?(cbiesinger)
Attachment #384397 -
Flags: review+
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 384396 [details] [diff] [review]
String API version
I prefer the other version
Attachment #384396 -
Flags: review?(cbiesinger) → review-
|
|
Assignee | |
Comment 7•16 years ago
|
||
Pushed changeset c68d36aeb5e3 to mozilla-central.
(In reply to comment #5)
> (From update of attachment 384397 [details] [diff] [review])
> Can you add a test for this? Should be enough to just call newURI, right?
Whoops, I forgot to add this...
|
|
||
Comment 8•16 years ago
|
||
Flags: in-testsuite+
|
||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•