499685 - skip slow running acceptance tests in test step, move to deeptest

Status: VERIFIED FIXED

Description

[Dan Schaffer]

on sparc,x64,ppc,ppc64 a set of 10 tests on debug and debugdebugger account for > 50% of the time

we should move the tests on the slower configurations to deep test phase

Comment 1

[Dan Schaffer]

Created attachment 384454 [details] [diff] [review]
patch

Comment 2

[Dan Schaffer]

Created attachment 389475 [details] [diff] [review]
add ppc deep test running slow acceptance tests

Comment 3

[Brent Baker]

Comment on attachment 389475 [details] [diff] [review]
add ppc deep test running slow acceptance tests

- Should use the "test_debug" and "test_debug_debugger" steps that are already defined
- should add a "test_debug64" that could be reused when an intel mac machine is added to the deep testing
- port to use in buildbot.tac is 1000
- the basedir in environment should be /Users/build/buildbot/$branch/mac-ppc-deep/$branch
- rename local scripts to not contain "-ppc"

Comment 4

[Dan Schaffer]

Created attachment 389530 [details] [diff] [review]
updated patch add deep for solaris, windows64, mac-ppc

also I changed all buildbot.tac from port 9750 to 1000.

Comment 5

[Brent Baker]

Comment on attachment 389530 [details] [diff] [review]
updated patch add deep for solaris, windows64, mac-ppc

+ with a couple of tweaks

- builder dependencies are incorrect, should depend on the proper *-test builder and not the windows-test builder
- rename the buildstep names to just be Testsuite_DebugDebugger and not contain "*64", this will make sure that the step name is matched on all builders
- solaris machine path is "/home/build/...." for buildbot.tac
- solaris is called "solaris-sparc" so maybe the deep should be "solaris-sparc-deep"
- proper config string for solaris is "sparc-sol-tvm-debug" not "solaris-tvm-debug"
- why does windows64 environment.sh set the shell_extension to nothing?

Comment 6

[Dan Schaffer]

pushed in changeset 2174 f6390cd96f53, still debugging a few hg problems

Comment 7

[Brent Baker]

Make sure the solaris-sparc-deep scripts are executable: 2203:f69378866c05

Comment 8

[Dan Schaffer]

Created attachment 390215 [details] [diff] [review]
add util_process_clean to deep, skip mops on ppc-mac-debug, +x solaris scripts

Comment 9

[Dan Schaffer]

Created attachment 390467 [details] [diff] [review]
patch to add winmo deep-test, for running slow acceptance tests

Comment 10

[Brent Baker]

Comment on attachment 390467 [details] [diff] [review]
patch to add winmo deep-test, for running slow acceptance tests

+ with the following quick fixes:

- why are the commented out esc buildsteps in the deep builders
- in the master.cfg you have the path set to slaves/winmobile-emulator-deep/scripts but the scripts are in (and have path information) for winmobile-arm-deep
- *interp-arm-emulator.sh has an incorrect --config string, remove double config and you also need to include -Dinterp in the config string
- wc-interp and jit scripts should have vmargs appended to the the --config string

Comment 11

[Dan Schaffer]

thanks for feedback.  on the commented out esc buildsteps, I was going to test if work on the deep test platforms before enabling esc builds.  We have only run on windows thus far.

Comment 12

[Dan Schaffer]

pushed patch for add winmo deep-test in revision changeset 2228 d3bc8fd964a6

Comment 13

[Dan Schaffer]

Created attachment 390812 [details] [diff] [review]
patch : deep tests are included and not matched by skip patterns

Comment 14

[Dan Schaffer]

closing bug by marking verified/fixed.

Comment 15

[Tamarin Bot]

changeset: 7314:325a5dd9f3c2
user:      Brent Baker <[e-mail]>
summary:   Bug 499685: move unicode test to deep for x64-lin as the testcase is taking over 7 minutes to run on vls images

http://hg.mozilla.org/tamarin-redux/rev/325a5dd9f3c2

Comment 16

[Tamarin Bot]

changeset: 7315:bdc1ba72a4e4
user:      Brent Baker <[e-mail]>
summary:   Bug 499685: move pauseForGCIfCollectionImminent test to the deep phase on MIPS as the testcase takes over 5 minutes to run

http://hg.mozilla.org/tamarin-redux/rev/bdc1ba72a4e4