Closed Bug 499781 Opened 11 years ago Closed 11 years ago

Move some methods from nsILink to nsIContent

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(2 files)

nsStyleUtil::IsHTMLLink is showing up in some of the profiles for the Dromaeo DOM tests. The cost seems to mosly come from QI'ing to nsILink. I have a patch that moves a couple of methods from nsILink to nsIContent so we can avoid the QI.
Attached patch v1Splinter Review
Attached patch v1 (diff -w)Splinter Review
Attachment #384476 - Flags: superreview?(bzbarsky)
Attachment #384476 - Flags: review?(bzbarsky)
Comment on attachment 384476 [details] [diff] [review]
v1 (diff -w)

> +    * Get a pointer to the fully href URI (fully resolved and canonicalized,

s/fully/full/

With that looks fine, but I'd like dbaron to look over the interface change too.
Attachment #384476 - Flags: superreview?(dbaron)
Attachment #384476 - Flags: superreview?(bzbarsky)
Attachment #384476 - Flags: review?(bzbarsky)
Attachment #384476 - Flags: review+
Comment on attachment 384476 [details] [diff] [review]
v1 (diff -w)

sr=dbaron, but could you add a comment in nsILink pointing to those three methods on nsIContent?

We might just want to eliminate the whole interface at this rate...
Attachment #384476 - Flags: superreview?(dbaron) → superreview+
http://hg.mozilla.org/mozilla-central/rev/002c13585ad5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.