499781 - Move some methods from nsILink to nsIContent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

nsStyleUtil::IsHTMLLink is showing up in some of the profiles for the Dromaeo DOM tests. The cost seems to mosly come from QI'ing to nsILink. I have a patch that moves a couple of methods from nsILink to nsIContent so we can avoid the QI.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v1 (diff -w)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 384476 [details] [diff] [review]
v1 (diff -w)

> +    * Get a pointer to the fully href URI (fully resolved and canonicalized,

s/fully/full/

With that looks fine, but I'd like dbaron to look over the interface change too.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 384476 [details] [diff] [review]
v1 (diff -w)

sr=dbaron, but could you add a comment in nsILink pointing to those three methods on nsIContent?

We might just want to eliminate the whole interface at this rate...

Comment 5

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/mozilla-central/rev/002c13585ad5