499824 - faststripe theme incompatible with personas

Status: RESOLVED WONTFIX

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Something in the faststripe theme is incompatible with Personas; we should fix this.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

OOC, do we think this is super-high priority for August ship? I'd put it lower than a lot of the other bugs.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I would too, but I think we'll have plenty of time -- there was a lot of interest in Personas as an easy touch customization for the browser, so it'd be nice to have it work.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Documenting the problem a bit more:
* Menu toolbar - text changes color & background image NOT applied
* Statusbar - text changes color & background image IS applied
* Navigation toolbar - no change
* bookmarks toolbar - text changes color & background image is NOT applied

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

So it looks like the fix is super simple, just matching WINCE in the os in Personas' chrome.manifest so that we use windowsxp's skin.

Duplicate http://hg.mozilla.org/labs/personas/file/c4cc874f1175/client/chrome.manifest#l15 use os=WINCE & we're done.

In the future, the themes may diverge enough that it'll warrant setting up a wince theme, but the winxp theme works now.

Comment 5

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

putting my above comment into patch form

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 385185 [details] [diff] [review]
Patch v0.1

Looks good, r=myk; Committed as changeset http://hg.mozilla.org/labs/personas/rev/691263c3f052.

Sorry, I forgot to change the author of the commit when I checked it in. :-/  I'm not sure if there's any way to fix that after the fact.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

I've pushed a new development build with the change:

https://people.mozilla.com/~cbeard/personas/dist/personas-dev.xpi

Comment 8

[Tony Chung [:tchung]]

Attachment: half of personas screenshot

reopening.  This is only half fixed.  See screenshot (personas is only showing up in the status bar, but not in the upper part of fastripe theme.

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Paul, can you take a look?

Comment 10

[Alfred Kayser]

Some themes, like my Nautipolis and LittleFox do actually support the use of Personas.
There should be a way to allow the combination of a Personas 'theme' with a normal 'Theme'. 
When Personas was just an extension this was possible (and still is via the extension), but now that FF3.6 has 'lwtheme' build in, it outcasts existing themes.
This outcasting behaviour is not Mozilla like, and one should allow theme extensions. 
Note, I have been theming Mozilla for 10 years now, ofwhich5 years for FF, and now this is stopped because of this.
I have invested time to support Personas in my themes (with great effect), but now Personas is refusing to support me....

Comment 11

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #10)
That's not what this bug is about. Please file a new bug if you have an enhancement request or specific bug report to file.

(In reply to comment #9)
> Paul, can you take a look?

From what I remember, Personas was just broken with trunk builds at the time. Is this still a problem or can we re-resolve the bug?

Comment 12

[Ryan Doherty (:rdoherty)]

wontfixing, personas + themes is now handled via Firefox. Please open/follow a bug under Firefox -> theme if this is still a problem.