499845 - Upgrade to SQLite 3.6.10 might have introduced a crash [@ getNextString ]

Status: VERIFIED WONTFIX

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Seth Spitzer]

upgrade to SQLite 3.6.10 might have introduced a crash 

See:

http://crash-stats.mozilla.com/report/index/c1457186-3975-4f3f-a9fa-fa3772090620
http://crash-stats.mozilla.com/report/index/f1c36a4a-fa74-4f68-bae1-75e352090619

I don't think that fx 3.0.12 or 3.5.x use fts, but there might be fx add-ons that use it.

I've seen similar crashes when moving from 3.6.7 to 3.6.10 for Postbox.

Comment 1

[Shawn Wilsher :sdwilsh]

It did, however, fix a number of crashes that users were seeing (not in FTS).  Do you know if newer sqlite's fix this issue?

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

http://www.sqlite.org/cvstrac/tktview?tn=3717

Fixed March 12, so the first release it would be in is 3.6.12.

The check-in comment was: Avoid fts3 crash on (MATCH '""') expressions.

I feel like this means code can easily workaround the problem.

Comment 3

[Seth Spitzer]

> Do you know if newer sqlite's fix this issue?

Shawn:  I have not tried a newer sqlite yet.

Andrew:  thanks for finding that ticket!  I'm not doing a (MATCH '""') expression, but it might be the same bug.  I've added a test case to that SQLite ticket.

Comment 4

[Seth Spitzer]

It looks like the fix for the ticket that Andrew found is in sqlite 3.6.12 (and later), see
http://www.sqlite.org/cvstrac/timeline?d=150&e=2009-Jun-23&c=2&px=&s=3&dm=1&a=1&m=1&w=1&t=1&x=1

Shawn:  trunk uses 3.6.14.2 but fx 3.5 uses 3.6.10?  

If so, I can go get a trunk build and the sqlite add on manager and confirm if this crashes 3.5 (but not the trunk)

  create virtual table test using fts3 (foo, bar);
  insert into test values ('abc','xyz');
  select * from test where test match 'foo:"b" "c"';

Comment 5

[Shawn Wilsher :sdwilsh]

Yes, trunk was upgraded in bug 493560.

Comment 6

[Seth Spitzer]

Firefox is on 3.6.16 (soon to be 3.6.16.1 for Fx 3.5.6).  With 3.6.16, this is no longer an issue, but may still be an issue with Firefox 3.0.x, but that is reaching end-of-life soon.  this might be wontfix or worksforme?  I'll let sdwilsh decide.

Comment 7

[Shawn Wilsher :sdwilsh]

We'll see if branch wants an upgrade to 3.6.16.1.  If not, this is WONTFIX.  The upgrade originally gave us more stability wins than we gained.

Comment 8

[Samuel Sidler (old account; do not CC)]

We only intend to upgrade SQLite on the 1.9.0 branch if there is a security issue found or if there is a major stability issue introduced somehow (through a places change or what have you).

Marking this as WONTFIX.