If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

PleaseAlloc() is not returning NULL when requesting more memory than the heaplimit

VERIFIED FIXED in flash10.1

Status

Tamarin
Garbage Collection (mmGC)
P3
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Brent Baker, Assigned: Tommy Reilly)

Tracking

unspecified
flash10.1
x86
Windows XP
Bug Flags:
in-testsuite ?
flashplayer-qrb +
flashplayer-triage +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

8 years ago
Created attachment 384605 [details] [diff] [review]
PleaseAlloc selftest

Setting the heaplimit to a low amount and then requesting a memory allocation that is larger than the heaplimit via GC::PleaseAlloc() should return NULL, however the the allocation is happening, GC::Size() is reporting that the size of the buffer is the size that was requested.
Flags: in-testsuite?
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
(Reporter)

Comment 1

8 years ago
Created attachment 384609 [details] [diff] [review]
v2. Selftest for PleaseAlloc()

If I add an additional PleaseAlloc() selftest to the end of the ST_mmgc_basic.st then I will actually see an "out of memory" error and the shell will exit with 128 exitcode.
Attachment #384605 - Attachment is obsolete: true

Updated

8 years ago
Assignee: nobody → treilly
Status: NEW → ASSIGNED
Flags: flashplayer-qrb? → flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.x
(Assignee)

Comment 2

8 years ago
changeset:   2048:ea1cfc4f4c4c
tag:         tip
user:        Tommy Reilly <treilly@adobe.com>
date:        Wed Jun 24 13:03:49 2009 -0400
summary:     Fix typo kCanFail->GCHeap::kCanFail
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 3

8 years ago
Created attachment 390248 [details] [diff] [review]
minor update to pleaseAlloc() tests
Attachment #384609 - Attachment is obsolete: true
Attachment #390248 - Flags: review?(brbaker)

Updated

8 years ago
Attachment #390248 - Attachment is patch: true
Attachment #390248 - Attachment mime type: application/octet-stream → text/plain
(Reporter)

Updated

8 years ago
Attachment #390248 - Flags: review?(brbaker) → review+

Updated

8 years ago
Status: RESOLVED → VERIFIED
(Reporter)

Comment 4

8 years ago
Dan looks like this patch was never submitted (from comment #3)
(Reporter)

Comment 5

8 years ago
Comment on attachment 390248 [details] [diff] [review]
minor update to pleaseAlloc() tests

Dan, still looks like this has never made it it. Can you rebase/retest your patch?

Updated

8 years ago
Attachment #390248 - Flags: review?(treilly)

Comment 6

8 years ago
does this need a new testcase?  tommy to review?  in-testsuite? incompatible with verified/fixed.
(Assignee)

Comment 7

8 years ago
Comment on attachment 390248 [details] [diff] [review]
minor update to pleaseAlloc() tests

invalid to call DumpMemoryInfoLocked w/o first obtaining the heap lock

invalid to set heapLimit below initialSize, we should enforce that but we don't
Attachment #390248 - Flags: review?(treilly) → review-

Updated

8 years ago
QA Contact: gc → dschaffe
You need to log in before you can comment on or make changes to this bug.