499921 - add support for NPAPI NPN_ScheduleTimer/NPN_UnscheduleTimer

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Aas]

We should add support for NPAPI NPN_ScheduleTimer/NPN_UnscheduleTimer. This was originally specified as part of the Cocoa NPAPI event model but it not specific to the Cocoa event model.

Comment 1

[Josh Aas]

Attachment: fix v1.0

Fully functional implementation with tests, but I think it leaks. More on that soon.

Comment 2

[Josh Aas]

Attachment: fix v1.1

Fixes memory leaks.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 384947 [details] [diff] [review]
fix v1.1

- In timerTest():

+  id->timerID1 = NPN_ScheduleTimer(npp, 50, false, timerCallback);
+  id->timerID2 = NPN_ScheduleTimer(npp, 150, true, timerCallback);
+
+  NPObject* windowObject;
+  NPN_GetValue(npp, NPNVWindowNPObject, &windowObject);
+  if (!windowObject) {
+    NPN_UnscheduleTimer(npp, id->timerID1);
+    NPN_UnscheduleTimer(npp, id->timerID2);
+    return false;
+  }

If you call NPN_GetValue() before you schedule the timers here you don't need to worry about unscheduling if getting the window fails here.

r+sr=jst. But was this discussed on plugin-futures yet? I know apple shipped this w/o any discussion, but I really don't think we should put this in the tree before we at least announce these API changes.

Comment 4

[Josh Aas]

Attachment: fix v1.2

Updated to current trunk, addresses jst's comment, includes some header file cleanup.

Comment 5

[Josh Aas]

We should file a bug about pausing NPAPI timers when a window minimizes. I think WebKit does that.

Comment 6

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/6135c784b458

Comment 7

[Josh Aas]

Filed bug 501702 about possibly pausing timers when windows minimize.