Closed
Bug 499992
Opened 16 years ago
Closed 16 years ago
nsMsgTemplateReplyHelper signed integer used for array index
Categories
(MailNews Core :: Composition, defect)
MailNews Core
Composition
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
|
707 bytes,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
mailnews/compose/src/nsMsgComposeService.cpp
In member function ‘virtual nsresult nsMsgTemplateReplyHelper::OnDataAvailable(nsIRequest*, nsISupports*, nsIInputStream*, PRUint32, PRUint32)’:
1105: warning: comparison between signed and unsigned integer expressions
1109: warning: comparison between signed and unsigned integer expressions
1117: warning: comparison between signed and unsigned integer expressions
Attachment #384663 -
Flags: superreview?(neil)
Attachment #384663 -
Flags: review?(neil)
|
||
Updated•16 years ago
|
Attachment #384663 -
Flags: superreview?(neil)
Attachment #384663 -
Flags: superreview+
Attachment #384663 -
Flags: review?(neil)
Attachment #384663 -
Flags: review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 384663 [details] [diff] [review]
used unsigned
Although you should probably change bodyOffset and readOffset to unsigned too.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Target Milestone: --- → Thunderbird 3.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•