Closed Bug 500012 Opened 13 years ago Closed 13 years ago

Extension pages visited through Extension panel are loaded with right panel in view

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: abillings, Assigned: vingtetun)

Details

Attachments

(1 file, 4 obsolete files)

If a user uses the "Go to page" option when looking at extensions in the extension panel, Fennec will load the page on addons.mozilla.org for the extension. When it loads the page, the right panel with the bookmark star, back and forward buttons, and options is visible on the screen. If the user reloads the page, the right panel is moved out of view. The page should load initially with the panel out of view.

Steps to Reproduce
1. Start Fennec and go to options
2. Select the extensions button
3. Search for an extension
4. When extension comes up, select "Go to page" underneath of it.

Result: Extension page will load with right panel in view.

This was found on my OS X build from 6/23/2009.
Comment on attachment 385126 [details] [diff] [review]
Add a call to BrowserUI.hideControls()

I tried that too. Try panning down on a webpage. Then pan to the right and open the add-on manager. Go to an Add-on page. The controls are out of the way, but the page is still panned down.
I see this as well as checkboard in the upper right corner of the screen
Comment on attachment 385126 [details] [diff] [review]
Add a call to BrowserUI.hideControls()

Use:

ws.panTo(0, -BrowserUI.toolbarH);
Attached patch Patch v0.2 (obsolete) — Splinter Review
(In reply to comment #4)
> (From update of attachment 385126 [details] [diff] [review])
> Use:
> 
> ws.panTo(0, -BrowserUI.toolbarH);

Thanks. So same stuff than bug 500503 you've resolved!
Attachment #385126 - Attachment is obsolete: true
Attached patch Patch V0.3 (obsolete) — Splinter Review
Change the newTab signature to allow passing a URI
Call newTab to use Mark's workaround
Changed the Browser.addTab(uri,true) calls in notification.xml and extensions.js to call BrowserUI.newTab(uri)
Attachment #385238 - Attachment is obsolete: true
Attachment #386009 - Flags: review?(mark.finkle)
Attached patch Updated patch (obsolete) — Splinter Review
[15:35]	<mfinkle>	vingtetun: also, if we feel BrowserUI.newTab is the high level function to use for adding tabs, we should probably use it here too:
[15:35]	<mfinkle>	http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#577
[15:35]	<vingtetun>	Yes there is but I assume that Browser.addTab is the low level stuff
[15:35]	<mfinkle>	vingtetun: yeah, that's my feeling too
[15:35]	<mfinkle>	addTab = low level
[15:36]	<mfinkle>	newTab = high level
Attachment #386009 - Attachment is obsolete: true
Attachment #386017 - Flags: review?(mark.finkle)
Attachment #386009 - Flags: review?(mark.finkle)
Attachment #386017 - Attachment is obsolete: true
Attachment #386017 - Flags: review?(mark.finkle)
Attachment #386036 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mobile-browser/rev/25ba06979a92
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified fixed.
bugspam
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.