500023 - Duplicate Upgrade the web buttons results in one button failing to detect the right browser

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[raymond [:retornam] (inactive)]

https://spreadfirefox.authstage.mozilla.com/affiliates/utw

adding two affiliate buttons  results in one button detecting the right browser and the other detecting the wrong one.

Comment 1

[raymond [:retornam] (inactive)]

on www.agbeame.org

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot showing IE 6 on http://agbeame.org

This shows the problem, using IE 6.

Comment 3

[Alex Buchanan [:abuchanan]]

I made some Javascript and button HTML changes to allow for putting the same button on a page multiple times.

Changes should show up soon.

Also, I removed /affiliates/test_utw and instead merged working previews into /affiliates/utw

You'll need to re-copy the button HTML to the test site.

Comment 4

[raymond [:retornam] (inactive)]

reopened because the page doesn't display correctly in ie6  https://spreadfirefox.authstage.mozilla.com/affiliates/utw

Comment 5

[Alex Buchanan [:abuchanan]]

ok, I think everything is working.

I made a javascript change that adds a fallback for browsers that don't support getElementsByClassName (apparently IE 8 still doesn't, shame on them)

I also made some style tweaks to the sidebar for IE 6, so it's not fubar.  You'll notice the 728x90 and 860x60 preview images are missing on /affiliates/utw in IE 6, this is on purpose.

thanks guys!

Comment 6

[raymond [:retornam] (inactive)]

verified fixed on
https://spreadfirefox.authstage.mozilla.com/affiliates/utw using ie6,ie8, opera,safari and firefox.thanks to  buchanae and  sir 'stephend' donner for their help and good work