Duplicate Upgrade the web buttons results in one button failing to detect the right browser

VERIFIED FIXED in 3.0.2

Status

Websites Graveyard
spreadfirefox.com
--
critical
VERIFIED FIXED
9 years ago
7 years ago

People

(Reporter: retornam, Unassigned)

Tracking

unspecified
3.0.2

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
https://spreadfirefox.authstage.mozilla.com/affiliates/utw

adding two affiliate buttons  results in one button detecting the right browser and the other detecting the wrong one.
(Reporter)

Comment 1

9 years ago
on www.agbeame.org
Created attachment 384691 [details]
Screenshot showing IE 6 on http://agbeame.org

This shows the problem, using IE 6.
(Reporter)

Updated

9 years ago
Blocks: 497436
No longer blocks: 497436
Blocks: 495099
I made some Javascript and button HTML changes to allow for putting the same button on a page multiple times.

Changes should show up soon.

Also, I removed /affiliates/test_utw and instead merged working previews into /affiliates/utw

You'll need to re-copy the button HTML to the test site.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 3.0.2
(Reporter)

Comment 4

9 years ago
reopened because the page doesn't display correctly in ie6  https://spreadfirefox.authstage.mozilla.com/affiliates/utw
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Severity: normal → critical
ok, I think everything is working.

I made a javascript change that adds a fallback for browsers that don't support getElementsByClassName (apparently IE 8 still doesn't, shame on them)

I also made some style tweaks to the sidebar for IE 6, so it's not fubar.  You'll notice the 728x90 and 860x60 preview images are missing on /affiliates/utw in IE 6, this is on purpose.

thanks guys!
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

9 years ago
verified fixed on
https://spreadfirefox.authstage.mozilla.com/affiliates/utw using ie6,ie8, opera,safari and firefox.thanks to  buchanae and  sir 'stephend' donner for their help and good work
Status: RESOLVED → VERIFIED
(Assignee)

Updated

7 years ago
Product: Websites → Websites Graveyard
You need to log in before you can comment on or make changes to this bug.