500067 - When calDavCalendar.js fails to retrieve an item, log the href for it.

Status: RESOLVED WORKSFORME

(Calendar :: Provider: CalDAV, defect)

Description

[Andrew Ruthven]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.11) Gecko/2009061317 Iceweasel/3.0.11 (Debian-3.0.11-1)
Build Identifier: 0.9

Currently if calDavCalendar.js fails to parse an iCalendar entry in a calDav retrieve it logs:

  failed to retrieve item

With no indication of what item caused the issue.  This makes it neigh on impossible to work out the issue.  Even with verbose logging enabled it doesn't tell you.

The attached patch logs the href of the item that fails to parse.

Reproducible: Always

Comment 1

[Andrew Ruthven]

Attachment: Patch to add href to log entry

Comment 2

[Martin Schröder [:mschroeder]]

Andrew, this patch does not apply anymore because for the next release the code of the CalDAV provider changed. Please, have a look at https://wiki.mozilla.org/Calendar:Build. Also, we use Hg/Mercurial as a DVCS now, see http://hg.mozilla.org/comm-central/.

Comment 3

[Stefan Sitter [:ssitter]]

Please retest with a recent 1.0pre nightly test builds. Seems to be fixed already by the checkin of bug 481825: http://hg.mozilla.org/comm-central/rev/2ebb18326ffb

Comment 4

[Andrew Ruthven]

Looking at commit it both resolves the behaviour I was seeing, and adds the appropriate logging.

I can't test it, as my version of Thunderbird is too old to run that codebase (even on Debian Unstable!).  However with reviewing the code I'm confident that it fixes the issue.

Thank you!