Closed Bug 500088 Opened 12 years ago Closed 11 years ago

CAIRO_HAS_DDRAW_SURFACE is not tested for on WINCE

Categories

(Firefox Build System :: General, defect)

x86
Windows Server 2003
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dougt, Assigned: dougt)

References

()

Details

Attachments

(1 file, 1 obsolete file)

We are using this #define now:

http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1245800341.1245800976.17871.gz#err5


I think the configure needs to change so that we test for DDRAW on wince.
Attached patch patch v.1Splinter Review
Assignee: nobody → doug.turner
Attachment #384780 - Flags: superreview?
Attachment #384780 - Flags: review?(vladimir)
tracking-fennec: --- → ?
Attachment #384780 - Flags: superreview? → superreview?(ted.mielczarek)
Attachment #384780 - Flags: superreview?(ted.mielczarek)
Attachment #384780 - Flags: superreview+
Attachment #384780 - Flags: review?(vladimir)
Attachment #384780 - Flags: review+
91a6e7db4db9
331299d69ad0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
tracking-fennec: ? → ---
Flags: in-testsuite-
OS: Mac OS X → Windows Server 2003
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
I'm confused by this bug:
it looks like the summary says there's a check missing on WinCE,
whereas the patch moves that check from the "WinCE only" block to the "all Windows" block.
What am I failing to understand?
Yeah, we definitely shouldn't be getting this warning on desktop Windows builds.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Maybe the test for WINCE is completely broken. This is the only line in configure.in using "$WINCE":
    if test -z "$WINCE"; then

In all the other places the test looks like this:
    case "$target" in
    *-wince|*-winmo)
Assignee: dougt → nobody
(In reply to comment #0)
> http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1245800341.1245800976.17871.gz#err5

Log is not available anymore: can't know what the error was :-(


(In reply to comment #2)
> 91a6e7db4db9
> 331299d69ad0

http://hg.mozilla.org/mozilla-central/rev/91a6e7db4db9
http://hg.mozilla.org/mozilla-central/rev/331299d69ad0


(In reply to comment #4)
> Yeah, we definitely shouldn't be getting this warning on desktop Windows
> builds.

Then the patch was just plain wrong: see bug 513613.


(In reply to comment #5)
> Maybe the test for WINCE is completely broken.

http://mxr.mozilla.org/comm-central/search?string=%5C%24WINCE%5B%5E_%5D&regexp=on&case=on

Afaict, that should be fine:
http://mxr.mozilla.org/mozilla-central/source/configure.in
{
359 dnl Do some special WinCE toolchain stuff
360 case "$target" in
361 *wince|*winmo)
375     export WINCE=1
403 esac
}
No longer blocks: 513613
Depends on: 513613
I didn't try to revert the CXXFLAGS change.

I tried to revert the cairo.h change but I got an error:
{
http://hg.mozilla.org/try/rev/369b75194eae
http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/sgautherie.bz@free.fr-369b75194eae/

/nsWindow.cpp(3257) : error C2065: 'mD2DWindowSurface' : undeclared identifier
/nsWindow.cpp(3273) : error C2061: syntax error : identifier 'gfxD2DSurface'
...
}
which I won't investigate and just leave the include were it is now.

I left some |AC_MSG_WARN([DirectDraw = ...| to help test this patch on WinCE (which there is no Try builder for (anymore)): not to be checked in as is.

dougt: does this break anything on WinCE?
Attachment #479691 - Flags: review?(pavlov)
Attachment #479691 - Flags: feedback?(doug.turner)
Comment on attachment 479691 [details] [diff] [review]
(Cv0) Revert initial bad fix(es), Be more documented and explicit
[Moved to bug 600714]

windows ce isn't support or actively developed.
[Mid-air collision detected!]

Damn, I've just noticed new bug 600714 this one depends on... :-/
Assignee: nobody → doug.turner
Status: REOPENED → RESOLVED
Closed: 12 years ago11 years ago
Resolution: --- → FIXED
Attachment #479691 - Attachment description: (Cv0) Revert initial bad fix(es), Be more documented and explicit → (Cv0) Revert initial bad fix(es), Be more documented and explicit [Moved to bug 600714]
Attachment #479691 - Attachment is obsolete: true
Attachment #479691 - Flags: review?(pavlov)
Attachment #479691 - Flags: feedback?(doug.turner)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.