500111 - Pending/Nominated add-ons filter broken

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[u278084]

I noticed that the AJAX look-up by add-on name/author's email is broken on preview and AMO, but not on my local box. I think because I only have 4 extensions in the queue.

STR :
1. To go the URL, you need editor privileges
2. Open up the Filter Queue
3. In the "Add-on or Author Email" textbox, enter the first add-on in the queue
4. Take a nap

AR :
The spinning icon goes on for a long period of time, perhaps forever

ER :
A list of e-mails and/or add-ons.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

I get a 401 Unauthorized returned to my GET request for:

GET /en-US/editors/addonAndAuthorLookup/pending?q=stephen&limit=40&timestamp=1245814696653 HTTP/1.1

Host: preview.addons.mozilla.org


<snip>

Keep-Alive: 300

Connection: keep-alive

X-Requested-With: XMLHttpRequest

Referer: https://preview.addons.mozilla.org/en-US/editors/queue/pending


HTTP/1.x 401 Unauthorized

Date: Wed, 24 Jun 2009 03:38:16 GMT

Server: Apache/2.2.3 (Red Hat)

X-Powered-By: PHP/5.1.6

X-AMO-ServedBy: pm-app-amo06

P3P: CP="NOI ADM DEV PSAi COM NAV OUR OTRo STP IND DEM"

Cache-Control: no-store, must-revalidate, post-check=0, pre-check=0, private, max-age=0

Pragma: private

Connection: close

Content-Type: text/html; charset=UTF-8

Comment 2

[Wil Clouser [:clouserw]]

https://addons.mozilla.org/en-US/editors/addonAndAuthorLookup/pending?q=t&limit=40&timestamp=1245814696653  wfm, but I'm an admin.

Comment 3

[Scott McCammon [:mccammos]]

wfm too, but the request does combine the results of 3 different fairly expensive queries. I can see potential for timeout.

Comment 4

[Wil Clouser [:clouserw]]

Collections have been the trouble lately.  Would this benefit by going through and doing some bindOnly() work before those queries?

Comment 5

[Scott McCammon [:mccammos]]

Collections are out of the picture as the queries are not using cake's ORM or joining into collections.

I am curious about Stephen's 401 on preview - that is a problem if he was an admin or editor. (I am neither on preview, so cannot verify there)

Comment 6

[Rey Bango]

This wfm as well in both preview & production.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> Collections are out of the picture as the queries are not using cake's ORM or
> joining into collections.
> 
> I am curious about Stephen's 401 on preview - that is a problem if he was an
> admin or editor. (I am neither on preview, so cannot verify there)

The account I log into preview with has both Admin and Editor privs.

Comment 8

[u278084]

(In reply to comment #2)
> https://addons.mozilla.org/en-US/editors/addonAndAuthorLookup/pending?q=t&limit=40&timestamp=1245814696653
>  wfm, but I'm an admin.

I get an Access Denied error. I only have developer + editor privileges.

Comment 9

[u278084]

Attachment: typo fix and conditional reversal

Turns out to be a permissions problem similar to bug 501345. Thanks stephend for pointing that out.

Comment 10

[Scott McCammon [:mccammos]]

Comment on attachment 386362 [details] [diff] [review]
typo fix and conditional reversal

Thanks!

Comment 11

[u278084]

Attachment: better patch

Another patch inspired by Scott (sorry for dumping this on you again)

Comment 12

[Scott McCammon [:mccammos]]

Comment on attachment 390975 [details] [diff] [review]
better patch

I'm sorry for creating the original broken code. Thanks for the fix!

Comment 13

[u278084]

In r30533. Thanks!

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; https://preview.addons.mozilla.org/en-US/editors/queue/pending is now nice and zippy -- tested both as an Admin and as an Editor.