500251 - Cannot set set Minefield as default browser on Windows CE

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P2)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

When setting Minefield as the default browser an error is thrown & subsequent runs of Minefield ask again. Error is transcribed (since copy & paste doesn't work)

uncaught exception: [Exception... "Component returned failure code: 0x8004005 (NS_ERROR_FAILURE) [nsIShellService.setDefaultBrowser]"  ...... location: "JS frame :: chrome://browser.content/browser.js :: delayedStartup :: line 1133" data: no]

Comment 1

[Robert Strong (they/them - no direct email)]

taking

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Still needs some cleanup. If someone with a device wants to try this out I'd appreciate it.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I'm not getting the error, but Minefield still doesn't think it's set as the default browser. Opening a link from Windows Media Player opens IE so it would appear to not be set (though WMP might be hard coded to use IE).

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: in progress 2

This should work for the most part.

We need to decide what protocols / files we want to handle. Here is a listing of what ie handles with Microsoft Windows CE .NET 4.2
http://msdn.microsoft.com/en-us/library/ms924682.aspx

Comment 5

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Confirming that the new patch works & we're taking over default browser for links from WMP & local .html files. We're opening everything in a new window instead of opening a new tab in the existing window. Filed bug 500770 for that.

Comment 6

[Robert Strong (they/them - no direct email)]

Handlers I suggest we take
htmlfile (in the current patch)
gifimage
jpegimage
bmpimage
pngimage
http (in the current patch)
https (in the current patch)
ftp (in the current patch)

I am planning on adding xml for Firefox so probable xmlfile as well

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 8

[Robert Strong (they/them - no direct email)]

Comment on attachment 386351 [details] [diff] [review]
patch rev1

While testing this it was found that the icons aren't properly associating and the registry values aren't saved if the system is hard booted.

Comment 9

[Robert Strong (they/them - no direct email)]

I have a fix for saving the registry values when the system is hard booted. I'll need to borrow a system to figure out what is going on with the icons.

Comment 10

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

I believe this will fix the remaining issues

Comment 11

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/89283ae6dccd

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: as checked in - removed one whitespace change that wasn't needed