Closed Bug 500284 Opened 12 years ago Closed 12 years ago

Middle-clicking roots of threads might cause the thread tree to jump a bit

Categories

(Thunderbird :: Folder and Message Lists, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: rain1, Assigned: rain1)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

STR:
1. Make sure you're running with the patch in bug 467768.
2. Scroll down to the bottom.
3. Make sure that one of the messages near the bottom is the root of a thread (best seen if the thread has ~5-6 messages). I can see this with both collapsed and expanded threads.
4. Middle-click this message.

The thread jumps up a bit -- my suspicion is that we're going wrong somewhere in our calculation of how far we are from the bottom.
Applies over the patch from bug 467768.
Attached patch patchSplinter Review
Duh.
Assignee: nobody → sid.bugzilla
Attachment #385198 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #385271 - Flags: review?(bugmail)
Attachment #385271 - Flags: review?(bugmail) → review+
Comment on attachment 385271 [details] [diff] [review]
patch

Very happy about the thorough unit tests!

mc.folderDisplay.view.dbView.doCommand can be mc.folderDisplay.doCommand but I won't lose sleep if it's not.
Pushed to c-c, with nit fixed: http://hg.mozilla.org/comm-central/rev/ff9b5051d01d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
Flags: in-testsuite+
Keywords: regression
You need to log in before you can comment on or make changes to this bug.