500284 - Middle-clicking roots of threads might cause the thread tree to jump a bit

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Rain [:rain1] (inactive)]

STR:
1. Make sure you're running with the patch in bug 467768.
2. Scroll down to the bottom.
3. Make sure that one of the messages near the bottom is the root of a thread (best seen if the thread has ~5-6 messages). I can see this with both collapsed and expanded threads.
4. Middle-click this message.

The thread jumps up a bit -- my suspicion is that we're going wrong somewhere in our calculation of how far we are from the bottom.

Comment 1

[Rain [:rain1] (inactive)]

Attachment: Mozmill test to demonstrate the problem

Applies over the patch from bug 467768.

Comment 2

[Rain [:rain1] (inactive)]

Attachment: patch

Duh.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 385271 [details] [diff] [review]
patch

Very happy about the thorough unit tests!

mc.folderDisplay.view.dbView.doCommand can be mc.folderDisplay.doCommand but I won't lose sleep if it's not.

Comment 4

[Rain [:rain1] (inactive)]

Pushed to c-c, with nit fixed: http://hg.mozilla.org/comm-central/rev/ff9b5051d01d