500298 - autocomplete / password manager broken

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Grey Hodge (jX)]

I have multiple gmail accounts, and as such am used to the drop down for multiple logins. Today's nightly however has no drop down and won't fill in anything unless you type out the entire username it has stored a password for. Type it out and tab away and it'll fill in the password, however.

Changelog (I think) from a working nightly to the broken one:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c575412d976a&tochange=5fe89f2c22f0

Comment 1

[(not currently active) Ted Mielczarek]

I've noticed that autocomplete in the assignee field of bugs stopped working for me recently, might be the same bug.

Comment 2

[(not currently active) Ted Mielczarek]

Yeah, works in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090623 Minefield/3.6a1pre, fails in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090624 Minefield/3.6a1pre, same changesets as comment 0.

Comment 3

[(not currently active) Ted Mielczarek]

Simple testcase:
data:text/html,<form action=""><input type="text" name="q"></form>

Enter something into the textbox, hit enter. On the next page, simply press the down arrow in the text field. I get autocomplete in 20090623, but not in 20090624.

Comment 4

[juan becerra [:juanb]]

This works for me using a couple of gmail accounts on. It also works on my Mac nightly with my crufty profile.

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090625 Minefield/3.6a1pre

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1pre) Gecko/20090625 Shiretoko/3.5pre

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)

> This works for me using a couple of gmail accounts on. It also works on my Mac
> nightly with my crufty profile.
> 
> Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090625
> Minefield/3.6a1pre

WorksForMe:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090622 Minefield/3.6a1pre
(test build); http://hg.mozilla.org/mozilla-central/rev/ce59685483a6
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090623 Minefield/3.6a1pre
2009-06-23-05-mozilla-central; http://hg.mozilla.org/mozilla-central/rev/c575412d976a

No dropdown at all:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090624 Minefield/3.6a1pre
2009-06-24-04-mozilla-central; http://hg.mozilla.org/mozilla-central/rev/5fe89f2c22f0
This build reported to
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox&maxdate=1245901931&hours=24
The (3 platforms) unit test build was orange at that time, but the errors are not obvious to me.

WorksForMe:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090625 Minefield/3.6a1pre
2009-06-25-04-mozilla-central; http://hg.mozilla.org/mozilla-central/rev/968dfbf1cee9
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090626 Minefield/3.6a1pre
2009-06-26-04-mozilla-central; http://hg.mozilla.org/mozilla-central/rev/a55b20529273
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090627 Minefield/3.6a1pre
2009-06-27-04-mozilla-central; http://hg.mozilla.org/mozilla-central/rev/b8cbe3c9542b
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090628 Minefield/3.6a1pre
2009-06-28-04-mozilla-central; http://hg.mozilla.org/mozilla-central/rev/ca23d3b5a999
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090629 Minefield/3.6a1pre
2009-06-29-04-mozilla-central; http://hg.mozilla.org/mozilla-central/rev/643cdff78555
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090630 Minefield/3.6a1pre
2009-06-30-04-mozilla-central; http://hg.mozilla.org/mozilla-central/rev/b1b2f9a366ca
+
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090713 Minefield/3.6a1pre
2009-07-13-04-mozilla-central; http://hg.mozilla.org/mozilla-central/rev/b9012a18d2c6

Fix timeframe:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5fe89f2c22f0&tochange=968dfbf1cee9
Does anyone know which of these changesets fixed this bug?


> Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1pre) Gecko/20090625
> Shiretoko/3.5pre

Yep, this bug is trunk only.


(In reply to comment #5)
> *** Bug 503724 has been marked as a duplicate of this bug. ***

Probably more followup than duplicate:
I was misleaded as this bug was still open.

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> Fix timeframe:
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5fe89f2c22f0&tochange=968dfbf1cee9

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090715 Minefield/3.6a1pre] (home, optim default) (W2Ksp4)

(http://hg.mozilla.org/mozilla-central/rev/5fe89f2c22f0)

Broken

(http://hg.mozilla.org/mozilla-central/rev/40c421123871)
(http://hg.mozilla.org/mozilla-central/rev/7f9ef4bef487)
(http://hg.mozilla.org/mozilla-central/rev/5f14dd5ec14a)

Fine.

Fix timeframe:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5fe89f2c22f0&tochange=40c421123871
3 changesets for bug 495983.