500309 - Stop button does not reliably show while pages are loaded

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Al Billings [:abillings - ex-MoCo]]

When a web page is being loaded, the reload button to the right of the urlbar is supposed to become a stop button until the page finishes loading. This is a smoketest, in fact. Unfortunately, while I have seen the stop button show up a few times, it does not reliably do so. Generally, the button will continue to be the reload button all the way through the page's rendering process. I tested this on a simple html page (hermetic.com) and my blog at openbuddha.com and saw no differences in behavior. 

I noticed this on the n810 but have reproduced it on OS X as well.

This was seen with the beta 2 candidate build from 6/24.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.1

When we enter in TOOLBARSTATE_LOADING we change the icon to 'stop' but just after we call showToolbar, which itself switch back the icon by calling _editToolbar.

We can just invert 
 icons.setAttribute("mode", "loading");
 this.showToolbar(URLBAR_FORCE);
to have the right behavior but I suppose we don't want to mess with the toolbar editing stuff while we are in loading state

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 385030 [details] [diff] [review]
Patch v0.1

I'd rather invert the loading code for now. I'm not sure how this change would affect the code in other places.

Also, this patch keeps the "I" cursor in the urlbar during the page load.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch V0.2

Done.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/718b075c44b4

Comment 5

[Al Billings [:abillings - ex-MoCo]]

Verified fixed.

Comment 6

[Aakash Desai [:aakashd]]

Litmus test case created for testing this in the future:

https://litmus.mozilla.org/show_test.cgi?id=7083

Comment 7

[Dão Gottwald [:dao]]

bugspam