500322 - "Find" button in download manager does nothing

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Al Billings [:abillings - ex-MoCo]]

If the user downloads a file in Fennec, it will appear in the download manager with its name, size, and the domain that it came from. If the user then selects the "Find" button for this file in the Download Manager, nothing will happen. 

Steps to Reproduce
1. Go to http://www.irs.gov/pub/irs-pdf/fw4.pdf and save the PDF when prompted.
2. Click on the options button in the right pane
3. Click on the download manager button in options
4. On the line for fw4.pdf in the download manager, click on "Find"

Result: Nothing happens

Comment 1

[Al Billings [:abillings - ex-MoCo]]

This was found in the beta 2 candidate build from 6/24.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

I have verified this bug is an issue on my n810 with a 6/24 build

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

nsLocalFileUnix ::Reveal() is broken on maemo

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I have not found any decent way to implement ::Reveal()

Since the viewable filesystem is so limited on Maemo, maybe we could just open the File Manager. Not the best "Find".

I am also open to removing this feature altogether.

Thoughts?

Comment 5

[Stuart Parmenter]

im ok with removing

Comment 6

[Aakash Desai [:aakashd]]

Can we get this removed (due to comment #4-5), so we don't have duplicate bugs coming in for this issue in the future?

Comment 7

[Benjamin Stover (:stechz)]

Attachment: Remove find button and its callback

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed: https://hg.mozilla.org/mobile-browser/rev/873d8e71a69e

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Forgot to mention, I removed a line of code that was accessing the "show-button" element in the XBL constructor.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

verified on n810 with 1.9.2 nightly 20090921