If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

multiple files in gl.jar contain invalid U+FEFF characters, breaks syntax check

RESOLVED FIXED

Status

Mozilla Localizations
gl / Galician
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Arne Goetje, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.11) Gecko/2009060309 Ubuntu/9.10 (karmic) Firefox/3.0.11
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.11) Gecko/2009060309 Ubuntu/9.10 (karmic) Firefox/3.0.11

locale/browser/places/moveBookmarks.dtd contains a U+FEFF character at the beginning of the first line, which is an illegal syntax. This prevents us from importing the gl.xpi into Launchpad for shipping it with the Ubuntu language-packs.

Patch is attached.

Reproducible: Always
(Reporter)

Comment 1

8 years ago
Created attachment 385033 [details] [diff] [review]
patch for locale/browser/places/moveBookmarks.dtd
(Reporter)

Updated

8 years ago
Summary: locale/browser/places/moveBookmarks.dtd contains invalid character → multiple files in gl.jar contain invalid U+FEFF characters, breaks syntax check
(Reporter)

Comment 2

8 years ago
Comment on attachment 385033 [details] [diff] [review]
patch for locale/browser/places/moveBookmarks.dtd

obsolete patch, as the charcater appears in multiple files.
Attachment #385033 - Attachment is obsolete: true
(Reporter)

Comment 3

8 years ago
Created attachment 385039 [details] [diff] [review]
Patch to remove the U+FEFF charcater from all locations

This actually affects multiple files:
locale/browser/places/moveBookmarks.dtd
locale/browser/searchbar.dtd
locale/gl/reporter/reporter.dtd
locale/gl/global-region/region.dtd
locale/gl/global/notification.dtd
locale/gl/global/dialogOverlay.dtd
locale/gl/global/global.dtd
locale/gl/global/datetimepicker.dtd
locale/gl/mozapps/update/errors.dtd

Patch is attached to fix all these files.

Comment 4

8 years ago
Hi:
I am Frco. Javier Rial, a member at galician localization team.
We, at galician team, want this issue to be fixed, so I'm asking here  for what are next steps?

I understand that I must apply the patch in our local repo, and then "push" the changes.
If it's not true, please, guide me to the right direction.

Thanks a lot for your help.

Comment 5

8 years ago
Hi:

Applied all those changes in gl translation:
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/gl/rev/e23511214d95

This rev shoud fix this problem.

Is necessary to do something else?.

Kind regards.
Frco. Javier Rial.

Comment 6

8 years ago
Seems like these are on 1.9.2 as well, marking FIXED.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.