500348 - multiple files in gl.jar contain invalid U+FEFF characters, breaks syntax check

Status: RESOLVED FIXED

(Mozilla Localizations :: gl / Galician, defect)

Description

[Arne Goetje]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.11) Gecko/2009060309 Ubuntu/9.10 (karmic) Firefox/3.0.11
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.11) Gecko/2009060309 Ubuntu/9.10 (karmic) Firefox/3.0.11

locale/browser/places/moveBookmarks.dtd contains a U+FEFF character at the beginning of the first line, which is an illegal syntax. This prevents us from importing the gl.xpi into Launchpad for shipping it with the Ubuntu language-packs.

Patch is attached.

Reproducible: Always

Comment 1

[Arne Goetje]

Attachment: patch for locale/browser/places/moveBookmarks.dtd

Comment 2

[Arne Goetje]

Comment on attachment 385033 [details] [diff] [review]
patch for locale/browser/places/moveBookmarks.dtd

obsolete patch, as the charcater appears in multiple files.

Comment 3

[Arne Goetje]

Attachment: Patch to remove the U+FEFF charcater from all locations

This actually affects multiple files:
locale/browser/places/moveBookmarks.dtd
locale/browser/searchbar.dtd
locale/gl/reporter/reporter.dtd
locale/gl/global-region/region.dtd
locale/gl/global/notification.dtd
locale/gl/global/dialogOverlay.dtd
locale/gl/global/global.dtd
locale/gl/global/datetimepicker.dtd
locale/gl/mozapps/update/errors.dtd

Patch is attached to fix all these files.

Comment 4

[Frco. Javier Rial]

Hi:
I am Frco. Javier Rial, a member at galician localization team.
We, at galician team, want this issue to be fixed, so I'm asking here  for what are next steps?

I understand that I must apply the patch in our local repo, and then "push" the changes.
If it's not true, please, guide me to the right direction.

Thanks a lot for your help.

Comment 5

[Frco. Javier Rial]

Hi:

Applied all those changes in gl translation:
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/gl/rev/e23511214d95

This rev shoud fix this problem.

Is necessary to do something else?.

Kind regards.
Frco. Javier Rial.

Comment 6

[Axel Hecht [:Pike]]

Seems like these are on 1.9.2 as well, marking FIXED.