500397 - event dialog: Renaming of File Menu to Event/Task Menu

Status: RESOLVED FIXED

(Calendar :: Dialogs, enhancement)

Description

[Markus Adrario [:Taraman]]

From the discussion in Bug 392021.

The Menu to modify the Item currently being edited is named "File" which is misleading.
This should be changed to "Event" or "Task" depending on which kind of item we are editing.

Set Milestone to 1.1 because this will have quite some l10n impact. The entity names for the Menu-Items should be renamed from event.menu.file.<something> to event.menu.item.<something> to keep it consistant.

Comment 1

[Markus Adrario [:Taraman]]

Attachment: Patch V1

A first version of the Patch, as proposed in description

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 427964 [details] [diff] [review]
Patch V1

>diff --git a/calendar/base/content/dialogs/calendar-event-dialog.js b/calendar/base/content/dialogs/calendar-event-dialog.js
>--- a/calendar/base/content/dialogs/calendar-event-dialog.js
>+++ b/calendar/base/content/dialogs/calendar-event-dialog.js
>@@ -390,6 +390,13 @@ function loadDialog(item) {
>         setElementValue("percent-complete-textbox", percentCompleteInteger);
>     }
> 
>+    // Set Item-Menu label to Event or Task
>+    let menuItem = document.getElementById("item-menu");
>+    menuItem.setAttribute("label", calGetString("calendar-event-dialog",
>+                                          isEvent(item) ? "itemMenuLabelEvent" : "itemMenuLabelTask"));
>+    menuItem.setAttribute("accesskey", calGetString("calendar-event-dialog",
>+                                          isEvent(item) ? "itemMenuAccesskeyEvent" : "itemMenuAccesskeyTask"));
Please use cal.isEvent()




>+<!-- These 2 entities are placeholders, values are set at runtime -->
>+<!ENTITY  event.menu.item.label                           "Item">
>+<!ENTITY  event.menu.item.accesskey                       "I">
If they are only placeholders, I don't think localizers should have to bother. I think its fine to just hardcode "Item" and add a comment to the code, that this will be replaced based on the item type, or even just default to "Event" and change if needed.



codewise r=philipp. I haven't tested this, but it looks like its doing what its supposed to do. Waiting for ui-r now.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 427964 [details] [diff] [review]
Patch V1

this looks good to me.

Comment 4

[Markus Adrario [:Taraman]]

Attachment: Patch V2

This is Version 2 of this Patch with the changes from comment #2

Comment 5

[Markus Adrario [:Taraman]]

Tested again and

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/6d33502640b4>

-> FIXED

Comment 6

[Stefan Sitter [:ssitter]]

It is not possible to open the menu via new keyboard shortcut Alt+T because Alt+T is already used for the Title field. Accesskeys must be unique.

Comment 7

[Markus Adrario [:Taraman]]

Confirmed.

Shall we reopen this bug or file a new one?

Any Ideas which Accesskey could be usable?

Comment 8

[Markus Adrario [:Taraman]]

I would propose tho name the menu "Item".
The Accesskey would then be "I", since that is free.

This kills the neat solution of naming it either Event or Task depending on the item, but for usability this is better than having two different accesskeys.

If I get no objections, I will prepare a patch the next days.

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

What about alt+a or alt+k ? I kind of like having the menu names being "Event" and "Task".

Comment 10

[Markus Adrario [:Taraman]]

Did you mean A or K as different key for the Task and E for Event, or A or K for both, having it marked e.g. Event (A) in the Menu?

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

Yes, a or k as an accesskey for the "Task" Menu, keeping alt+t for the title field, and whatever we have (alt+e ? ) for the event menu.

Comment 12

[Stefan Sitter [:ssitter]]

None of the access keys in "Event" is available. Alt+E = Edit menu, Alt+V = View menu, Alt+N = End date, Alt+T = Title.

You could revert to the previously used Alt+F to keep keyboard compatibility to previous releases and to keep the same shortcuts in event and task layout.

Comment 13

[Markus Adrario [:Taraman]]

Attachment: Accesskey correction Patch V1

Using "F" for the moment sounds reasonable to me.

Comment 14

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 439694 [details] [diff] [review]
Accesskey correction Patch V1

>-itemMenuAccesskeyEvent=t
>+itemMenuAccesskeyEvent=F
> itemMenuLabelTask=Task
>-itemMenuAccesskeyTask=T
>+itemMenuAccesskeyTask=F
Changing properties needs a string name change. Sorry, its not as simple as that.

r=philipp with that changed and the corresponding changes in the files these are used.

Comment 15

[Markus Adrario [:Taraman]]

Attachment: Accesskey correction Patch V1.1

like this?

Comment 16

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 440775 [details] [diff] [review]
 Accesskey correction Patch V1.1

r=philipp and approved for checkin if done until Saturday (or whenever we announce the string freeze, may be postponed until Monday)

Comment 17

[Markus Adrario [:Taraman]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/4c2ef4efef83>

-> FIXED

Comment 18

[Markus Adrario [:Taraman]]

Pushed to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/1d5454c29dfe>

-> FIXED