500406 - add support for NPN_ConvertPoint on all platforms

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Aas]

We should add support for NPN_ConvertPoint to our NPAPI implementation.

Comment 1

[Josh Aas]

Modifying this bug to be specifically about expanding our implementation for all platforms. Right now calling NPN_ConvertPoint will fail on all platforms except for Mac OS X.

Comment 2

[Josh Aas]

Attachment: test v1.0

First revision of a test for NPN_ConvertPoint.

Comment 3

[Josh Aas]

Attachment: test v1.1

Fix some bugs in the test.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We need a frame point-conversion function that uses nsIFrame::GetTransformMatrix so it works with transforms.

Comment 5

[Josh Aas]

Attachment: test v1.2

Might as well get this into the tree now as a Mac-only test. It passes with our existing impl.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+* convertPointMatch(sourceSpace, sourceX, sourceY, destSpace, destX, destY)
+The plugin uses NPN_ConvertPoint to convert sourceX and sourceY from the source
+to dest space and returns true if the results from NPN_ConvertPoint match the
+destX and destY coordinates.

I'd prefer to have convertPointX and convertPointY, both of which take (sourceSpace, sourceX, sourceY, destSpace), and do the comparison in the test code. That way we get better test failure output if something fails, and the method might be useful for other things later on.

Comment 7

[Josh Aas]

Attachment: test v1.3

Comment 8

[Josh Aas]

test v1.3 pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/e1e6c6e410d8

Comment 9

[Josh Aas]

In order to do this we'll need to write up a spec and propose it. Until then, NPN_ConvertPoint will be only for the Cocoa event model.

https://wiki.mozilla.org/NPAPI

Comment 10

[Benjamin Smedberg]

Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.