Status

()

VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: mozilla, Assigned: mz)

Tracking

({verified1.9.1.1})

3.5 Branch
x86
OS/2
verified1.9.1.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments, 1 obsolete attachment)

(Reporter)

Description

9 years ago
Now that the new Firefox icon for the other platforms is landed (see bug 500033) we can also create a new .ico file for OS/2. I guess one could either take the Windows .ico file from attachment 384726 [details] as a base or start from higher or matching resolution PNG images as published at <http://blog.mozilla.com/faaborg/2009/06/18/the-new-firefox-icon/>.

Stefan, you did great work to adapt the SeaMonkey icon, do you still have the means to do this again now?
(Assignee)

Comment 1

9 years ago
Created attachment 385172 [details]
Firefox icon scaled down from 512 png without shadow

Source is from 
http://blog.mozilla.com/faaborg/2009/06/18/the-new-firefox-icon/

Comment 2

9 years ago
(In reply to comment #1)
> Created an attachment (id=385172) [details]
> Firefox icon scaled down from 512 png without shadow
I took a look at it, the 24bits look nice in all resolutions, all other color depths are black...

Comment 3

9 years ago
They updated document.{ico,png} as well. Another source for the ico files (if they are of any help for you) is:
http://hg.mozilla.org/releases/mozilla-1.9.1/file/d4681ff6dfb8/other-licenses/branding/firefox/{firefox,document}.ico
Out of curiosity what size and formats do you need to generate OS/2 icons?

Comment 5

9 years ago
(In reply to comment #4)
> Out of curiosity what size and formats do you need to generate OS/2 icons?

We have a different ico format than windows, but there are programs available to convert, so that is not big deal. In part, we have the same formats than windows 32x32 and 16x16, and these convert fine from the windows ico. In addition we need 40x40 and 20x20. Anything bigger would display as well, e.g 48x48, but doesn't fit to our overall layout. Color depth is 24bit, 8bit, and 4bit.
(Assignee)

Comment 6

9 years ago
Created attachment 385335 [details]
v2 of Firefox icon scaled down from 512 png without shadow [Checked in comment 10]

Version 2 of Firefox icon scaled down from 512 png without shadow

Now checked every color depth and resolution ( had some invalid display masks in previous version ).
Source is from 
http://blog.mozilla.com/faaborg/2009/06/18/the-new-firefox-icon/
Attachment #385172 - Attachment is obsolete: true
(Assignee)

Comment 7

9 years ago
(In reply to comment #3)
> They updated document.{ico,png} as well. Another source for the ico files (if
> they are of any help for you) is: http://hg.mozilla.org/releases/mozilla-1.9.1/file/d4681ff6dfb8/other-licenses/branding/firefox/{firefox,document}.ico

Any possibility to get the files directly from the web interface ?
(Reporter)

Comment 8

9 years ago
Yes, when displaying the file (where you just see "(binary:application/octet-stream)") use the "raw" link at the top. Or just download

http://hg.mozilla.org/releases/mozilla-1.9.1/raw-file/d4681ff6dfb8/other-licenses/branding/firefox/document.ico
http://hg.mozilla.org/releases/mozilla-1.9.1/raw-file/d4681ff6dfb8/other-licenses/branding/firefox/firefox.ico
(Reporter)

Comment 9

9 years ago
Comment on attachment 385335 [details]
v2 of Firefox icon scaled down from 512 png without shadow [Checked in comment 10]

Thanks, Stefan. This looks great. I'll get this in soon.
Attachment #385335 - Flags: review+
(Reporter)

Updated

9 years ago
Assignee: nobody → mz
Status: NEW → ASSIGNED
(Reporter)

Comment 10

9 years ago
Comment on attachment 385335 [details]
v2 of Firefox icon scaled down from 512 png without shadow [Checked in comment 10]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/c8808dd65f45
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/443e352ba424

BTW, the bug for the document icons was bug 473343. I'll leave this bug open for that.
Attachment #385335 - Attachment description: v2 of Firefox icon scaled down from 512 png without shadow → v2 of Firefox icon scaled down from 512 png without shadow [Checked in comment 10]
(Assignee)

Comment 11

9 years ago
> BTW, the bug for the document icons was bug 473343. I'll leave this bug open
> for that.
Should I place document-os2.ico here or at bug 473343 ?
(Reporter)

Comment 12

9 years ago
Here, please. (I just wanted to post a reference to the other bug.)
(Assignee)

Comment 13

9 years ago
Created attachment 385628 [details]
v1 of document-os2.ico apapted from document.png
(Assignee)

Comment 14

9 years ago
Created attachment 385630 [details]
v4 of firefox-os2.ico

Not very important but I remembered 4-bit should use system colors. ( So the user interface on 256 color devices leaves 240 colors for displaying pictures. ) Corrected this for completness.
(Assignee)

Comment 15

9 years ago
Created attachment 385631 [details]
v5 of firefox-os2.ico [Checked in comment 26]

Imho a little bit smoother and clearer.
(Assignee)

Comment 16

9 years ago
Created attachment 385632 [details]
png with comparison of firefox-os2.ico v4 and v5

Comment 17

9 years ago
(In reply to comment #15)
> Created an attachment (id=385631) [details]
> v5 of firefox-os2.ico
> 
> Imho a little bit smoother and clearer.
I agree, v5 looks very nice in 24 and 8bit, but the 4bits of v4 and v5 look a bit strange (e.g. yellow pixels all over), 4bit was nicer in the v2.
Another comment on document-os2.ico. It appears you took the "linux" png as a template where the logo is put aside of the "page". In the windows version of document.ico, the firefox logo is centered on the "page", 
https://bugzilla.mozilla.org/attachment.cgi?id=382681
Nevertheless, your icons look way better than that we had up to now, thanks.
(Reporter)

Comment 18

9 years ago
Walter, I think Stefan is right in that one should use the system palette for 4bit icons. And there you are limited with what colors are available. This is the same for the current SeaMonkey icon, too (just that there the available colors match the icon colors better). I should have seen that when I looked at the icon that I checked in.

As for document-os2.ico I don't think it matters, if it is built from the original Windows or Linux version. We should just be consistent when the Thunderbird icon needs to be redone (later this year?).

Stefan, if you are still happy -- after thinking it over for three days -- with the current state of firefox-os2.ico v5 and document-os2.ico, I would check them in.
(Assignee)

Comment 19

9 years ago
(In reply to comment #18)
> Walter, I think Stefan is right in that one should use the system palette for
> 4bit icons.

The background ( so far I understand it ) : 4-bit icons are for 8-bit environments ( like some mobile devices - less data transfer, more operation time ).
The general idea is to restrict colors of the user interface to 16 system colors. So 240 colors remain available. Those colors sensibly adapted, your can achieve pretty good results in diplaying content - like pictures or rendered font with different font and background colors.
Otherwise 16 icons with differently adapted colors would eat up all palette colors. Nothing left for content. 

> As for document-os2.ico I don't think it matters, if it is built from the
> original Windows or Linux version. We should just be consistent when the
> Thunderbird icon needs to be redone (later this year?).

The other is already in work. But I don't have much spare time, so it might take two or three days until I find the time.

> Stefan, if you are still happy -- after thinking it over for three days --
> with the current state of firefox-os2.ico v5 and document-os2.ico, I would
> check them in.

I think both are "technically" OK and the best compromise achievable ( between black and white background without alpha channel ). If you want the matter be closed, take them. Otherwise I provide a document-os2.ico v2 apdapted from the Windows source.
(Reporter)

Comment 20

9 years ago
I realized that I have never seen document.ico used anywhere on OS/2. It is used on Windows (through toolkit/xre/nsNativeAppSupportWin.h) but on OS/2 the DOCUMENT_ICO property indeed seems to be unused. We do use FIREFOX_ICO in browser/app/splashos2.rc to link it into the resources of firefox.exe but not the document. Does OS/2 actually have a mechanism to have one icon for the app but another icon for documents that are associated with that app (or program object)?
(Assignee)

Comment 21

9 years ago
Created attachment 386806 [details]
v2 of document-os2.ico apadpted from Windows png [Checked in comment 26]
(Assignee)

Comment 22

9 years ago
Created attachment 386807 [details]
comparison of document-os2.ico v1 and v2
(Assignee)

Comment 23

9 years ago
(In reply to comment #20)
> ... Does OS/2 actually have a mechanism to have one icon for the app but
> another icon for documents that are associated with that app (or program
> object)?
Two program objects would be a possibility. One without ( firefox.ico ) and the other with ( document.ico ) assignments to extensions and classes.
(Reporter)

Comment 24

9 years ago
Comment on attachment 385631 [details]
v5 of firefox-os2.ico [Checked in comment 26]

OK, so I convinced myself that this is the best version of firefox.ico.
Attachment #385631 - Flags: review+
(Reporter)

Updated

9 years ago
Attachment #386806 - Flags: review+
(Reporter)

Comment 25

9 years ago
Comment on attachment 386806 [details]
v2 of document-os2.ico apadpted from Windows png [Checked in comment 26]

...and this one is the nicer one for document-os2.ico. While I like v1 better on dark backgrounds, the fox looks a bit ragged on bright backgrounds. On 16x16 the fox is hardly recognizable, but I guess we can live with that as the colors still give a good hint.

I'll get both in.
(Reporter)

Comment 26

9 years ago
Pushed to trunk and 1.9.1:
http://hg.mozilla.org/mozilla-central/rev/910b07444baf
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7b9cc253bcb8

Let's mark this resolved and discuss possibilities of using document-os2.ico in bug 502350 that I just filed for this purpose.

Many thanks, Stefan!


(Hmm, this should be fixed1.9.1.1 but that doesn't exist yet, so I'm using fixed1.9.1.)
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
(Reporter)

Updated

9 years ago
Attachment #385631 - Attachment description: v5 of firefox-os2.ico → v5 of firefox-os2.ico [Checked in comment 26]
(Reporter)

Updated

9 years ago
Attachment #386806 - Attachment description: v2 of document-os2.ico apadpted from Windows png → v2 of document-os2.ico apadpted from Windows png [Checked in comment 26]
(Reporter)

Updated

9 years ago
Keywords: fixed1.9.1 → fixed1.9.1.1
Can someone that has OS/2 here verify this fix on trunk and a 1.9.1 nightly?  Please change the status and keyword to verified also.   Thanks.
(Reporter)

Updated

9 years ago
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1.1 → verified1.9.1.1
You need to log in before you can comment on or make changes to this bug.