500454 - Cleanup notifications

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Notifications use a tiny image (left side) that is too small and taking up space, especially for portrait. We should remove it.

The buttons are not normal Fennec buttons, have unused space for an extra label and are missing bottom padding. We should just use a normal button.

The "close" button is too small. We should use the new close button.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Oh, this patch also adds the new close button to the findbar

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 385158 [details] [diff] [review]
patch

>diff --git a/themes/hildon/notification.css b/themes/hildon/notification.css

>+notification .messageImage {
>+  display: none;

Why not just remove it from the <content>?

>+notification .messageCloseButton {
>+  list-style-image: url("chrome://browser/skin/images/tab-close.png");

Perhaps we should rename this image to just "close.png" given that it isn't tab specific.

>\ No newline at end of file

add one?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> >+notification .messageImage {
> >+  display: none;
> 
> Why not just remove it from the <content>?

Done

> >+notification .messageCloseButton {
> >+  list-style-image: url("chrome://browser/skin/images/tab-close.png");
> 
> Perhaps we should rename this image to just "close.png" given that it isn't tab
> specific.

I have another patch for that

> >\ No newline at end of file
> 
> add one?

Done

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/mobile-browser/rev/342e81dcc2be

Comment 5

[Dão Gottwald [:dao]]

bugspam