Closed Bug 500466 Opened 15 years ago Closed 15 years ago

avmshell crashes on P3 cpu machine with JIT enabled

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P2)

Product:
Tamarin Graveyard
Component:
Baseline JIT (CodegenLIR)
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
flash10.1

People

(Reporter: brbaker, Assigned: rreitmai, NeedInfo)

References

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey)

Attachments

(1 file)

add sse detection to backend
1.46 KB, patch
n.nethercote
: review+
edwsmith
: superreview+
Details | Diff | Splinter Review 
Running the shell on a P3 class machine with the jit enabled causes the shell to crash. 

All acceptance test pass when running with -Dinterp, -Dnosse and "-Ojit -Dnosse" switches.

Probably exact same issue as bug #500277
Flags: in-testsuite+
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
If helpful I can recompile the shell and keep the pdb file and post pdb + dumpfile
I suspect you won't need symbols: if you can catch it in windbg plain disassembly without symbols will tell you what instruction is being executed.
I loaded the avmplus.dmp file and it was pointing to this as an illegal instruction:

   01B2523B  mov         dword ptr [ebx+44h],0 
   01B25242  mov         dword ptr [ebx+48h],0FFFFFFFFh 
   01B25249  mov         dword ptr [ebx+4Ch],7FEFFFFFh 
   01B25250  mov         dword ptr [ebx+24h],1 
   01B25257  mov         dword ptr [ebx+50h],2 
   01B2525E  mov         dword ptr [ebx+54h],3 
   01B25265  mov         dword ptr [ebx+20h],1 
-> 01B2526C  xorpd       xmm1,xmm1 
   01B25270  cvtsi2sd    xmm1,ecx 
   01B25274  movsd       xmm0,xmm1 
   01B25278  divsd       xmm0,xmm1 
   01B2527C  movq        mmword ptr [ebx+28h],xmm0
That's an SSE instruction and we don't have SSE here...
Probably stating the obvious...SSE detection logic most likely broken.
Assignee: nobody → rreitmai
Flags: flashplayer-qrb? → flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.x
Status: NEW → ASSIGNED
Depends on: 475779
Priority: P3 → P2
OS: Windows XP → All
Code extracted from jstracer.
Attachment #414362 - Flags: superreview?(edwsmith)
Attachment #414362 - Flags: review?(nnethercote)
Attachment #414362 - Flags: review?(nnethercote) → review+
Comment on attachment 414362 [details] [diff] [review]
add sse detection to backend

+1 for removing that VMPI_getDate() call.

-1 for inserting extraneous whitespace at the bottom.  Might as well fix that before committing.
Attachment #414362 - Flags: superreview?(edwsmith) → superreview+
pushed http://hg.mozilla.org/projects/nanojit-central/rev/ab0a893ffe83
Whiteboard: fixed-in-nanojit
Rick can this be marked as resolved? I ran a full acceptance pass in tamarin-redux (rev ca1d9443d0fc) on a P3 windows machine and all tests are passing (release, debug, debugger, interp, jit), including -Djitordie
The change has migrated to tamarin.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin
Verified fixed in tamarin
Status: RESOLVED → VERIFIED
http://hg.mozilla.org/tracemonkey/rev/4a3708de934a
Whiteboard: fixed-in-nanojit, fixed-in-tamarin → fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey
Flags: needinfo?(rreitmai)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: