unable to install add-ons extensions

VERIFIED FIXED

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: jmaher, Assigned: vingtetun)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
on both maemo and winmo (beta2 build1), I got to add-ons manager search for script, get no-script and AutoPager.  I click the install button and I get the top part of a grey box, but I cannot scroll into it.  This is the case for both of the mentioned add-ons.
I went to the extensions panel in options, searched for "script" and installed no script there with no problems.
This is on my n810 with Maemo.
Created attachment 385292 [details] [diff] [review]
Patch v0.1

In fact the extension should install, the top bar seen is a progress element that should display the current download progress.
The progress display have been broken here http://hg.mozilla.org/mobile-browser/rev/5bbb4c203890 
The patch basically revert the extensions.js change done in this changeset to show how it should work.


It is not the good way to do since we already have an observer for the xpi download progress. 
Mark, you probably know this part very well, any hint?
I switched to weak references purely so I wouldn't need to un register. But since we have an ExtensionsView.uninit() and, more importantly, the code is broken - we should change back :)
(In reply to comment #3)
 
> It is not the good way to do since we already have an observer for the xpi
> download progress. 

What is "not a good way"?
(In reply to comment #5)
> (In reply to comment #3)
> 
> > It is not the good way to do since we already have an observer for the xpi
> > download progress. 
> 
> What is "not a good way"?

I saying that cause browser.js#173 already do os.addObserver(gXPInstallObserver, "xpinstall-download-started", false); but its like gXPInstallObserver do nothing on this topic. 
Not sure why it is here?
Ok, now I see what it is for in browser.js after have read your comments on bug 437959. 
I supposed it is unused now but it can be in the future.
Ah, I see what you mean now. We really only need to handle "xpinstall-install-blocked" in browser.js for now.
Can you remove the addEventListener / removeEventListener in this patch ?
do you mean addInstallListener/removeInstallListenerAt?
Created attachment 386240 [details] [diff] [review]
Patch V0.2

Yes :)
Assignee: nobody → 21
Attachment #385292 - Attachment is obsolete: true
Attachment #386240 - Flags: review?(mark.finkle)
Attachment #386240 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mobile-browser/rev/cb8df78a156b
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 14

9 years ago
verified with beta3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.