Closed Bug 50051 Opened 24 years ago Closed 24 years ago

Setting foreground color then typing doesn't change text color

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Platform:
All
Mac System 8.5
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: sfraser_bugs, Assigned: saari)

Details

(Whiteboard: possible fix in hand) 

If I change the foreground color using the toolbar wiget, then type, the new text 
does not come out using the new color. It's a if the type-in state is not getting 
the current color.
I don't see this problem on Windows.
I select a color using toolbar widget, then 
immediately type, and it's in the color I just picked. I tried both with caret
inside existing text, and at end of existing text, and in a new page (as first
action - change color).
Look for the line:
window.editorShell.SetTextProperty("font", "color", gColorObj.TextColor);
in editor.js and dump out the color gColorObj.TextColor to be sure you're 
getting the correct value from the colorpicker dialog.

dup of 49952

*** This bug has been marked as a duplicate of 49952 ***
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
uduping; i'm on drugs
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Simon: I'm still not seeing any problem with today's Window's build.
The problem here is that on Mac, bringing up the color picker clobbers focus, so 
you have to click back in the document to focus it before typing. This click then 
clobbers the type-in state.

So some focus thing is busted.

handing off to xpfe
Assignee: jfrancis → ben
Status: REOPENED → NEW
Component: Editor → XP Apps: GUI Features
QA Contact: sujay → sairuh
After launching the colorpicker or any other dialog, there are explicit
window._content.focus() calls. Do you see the same problem with other dialogs?
If, as Simon states, there's a focus problem on the Mac, lets file a bug on that 
issue, not on the color setting code.
I don't think this belongs to Ben! Maybe Saari?
Assignee: ben → saari
window.content.focus calls for which window? The dialog or the content area?
window._content.focus() in the main editor content window.
over to xp widget land [methinks]...
Component: XP Apps: GUI Features → XP Toolkit/Widgets
QA Contact: sairuh → jrgm
Whiteboard: possible fix in hand
This needs to escalated, else the colorpicker is useless on Mac
Fixed
Status: NEW → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.