50051 - Setting foreground color then typing doesn't change text color

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Simon Fraser [no longer active]]

If I change the foreground color using the toolbar wiget, then type, the new text 
does not come out using the new color. It's a if the type-in state is not getting 
the current color.

Comment 1

[Charles Manske]

I don't see this problem on Windows.
I select a color using toolbar widget, then 
immediately type, and it's in the color I just picked. I tried both with caret
inside existing text, and at end of existing text, and in a new page (as first
action - change color).

Comment 2

[Charles Manske]

Look for the line:
window.editorShell.SetTextProperty("font", "color", gColorObj.TextColor);
in editor.js and dump out the color gColorObj.TextColor to be sure you're 
getting the correct value from the colorpicker dialog.

Comment 3

[Joe Francis]

dup of 49952

*** This bug has been marked as a duplicate of 49952 ***

Comment 4

[Joe Francis]

uduping; i'm on drugs

Comment 5

[Charles Manske]

Simon: I'm still not seeing any problem with today's Window's build.

Comment 6

[Simon Fraser [no longer active]]

The problem here is that on Mac, bringing up the color picker clobbers focus, so 
you have to click back in the document to focus it before typing. This click then 
clobbers the type-in state.

So some focus thing is busted.

Comment 7

[Joe Francis]

handing off to xpfe

Comment 8

[Charles Manske]

After launching the colorpicker or any other dialog, there are explicit
window._content.focus() calls. Do you see the same problem with other dialogs?
If, as Simon states, there's a focus problem on the Mac, lets file a bug on that 
issue, not on the color setting code.
I don't think this belongs to Ben! Maybe Saari?

Comment 9

[saari (gone)]

window.content.focus calls for which window? The dialog or the content area?

Comment 10

[Charles Manske]

window._content.focus() in the main editor content window.

Comment 11

[sairuh (rarely reading bugmail)]

over to xp widget land [methinks]...

Comment 12

[Charles Manske]

This needs to escalated, else the colorpicker is useless on Mac

Comment 13

[saari (gone)]

Fixed