500522 - print exit names instead of numbers

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Annoying to keep opening jstracer.h and see what the latest ExitType values are.

Example of new output:

leaving trace at trace-test.js:614@47, op=lt, lr=0x2d54a4, exitType=loop, sp=2, calldepth=0, cycles=51696

Comment 1

[Brendan Eich [:brendan]]

You could just have one param to the EXITCODE macro, avoid redundancy at the price of UPPERCASE shouting. But IMHO that makes the verbose output easier to scan for, e.g. MISMATCH.

For short lists you might want to avoid a .tbl source file by using the macro-map trick v8 uses all over:

#define EXITCODES(_) _(BRANCH) _(CASE) _(DEFAULT) _(LOOP) ...

and call it with different macros as actual parameters (macro names).

/be

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: advice from comment #1

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/tracemonkey/rev/310c9f052f8e

with one change from jwalden, use JS_ARRAY_LENGTH

Comment 4

[Brendan Eich [:brendan]]

Nit follopup fodder: those major comments embedded in the list macro are no fun to maintain, hardly more fun to read ;-). Pulling out a major doc-comment that makes codename-tagged paragraphs, one per code, seems better.

/be

Comment 5

[Jeff Walden [:Waldo]]

...but only if you flesh out the documentation for the remaining exit types, which I consider a generalizable argument for placing documentation for a thingamabob, by the thingamabob.  Without having all of them documented, it's somewhat less obvious when one is missing documentation, and a random FIXME: paragraph is more ugly than what exists now (if you actually think what exists now is ugly, I just don't see it).