Closed
Bug 500533
Opened 15 years ago
Closed 15 years ago
Firefox missing app icon on Windows CE - incorrect icon resource id's
Categories
(Firefox :: Shell Integration, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3.6a1
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
(Whiteboard: [nv])
Attachments
(1 file, 1 obsolete file)
589 bytes,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #499810 +++ Firefox doesn't have an application icon on Windows CE; the Fennec folks know how to do this, need to find out from mfinkle or dougt what things we need to add to our build. e This is a spinoff for fixing the icon resource id's
Assignee | ||
Comment 1•15 years ago
|
||
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #385241 -
Flags: review?(vladimir)
Assignee | ||
Updated•15 years ago
|
Summary: Firefox missing app icon on Windows CE → Firefox missing app icon on Windows CE - incorrect icon resource id's
Assignee | ||
Updated•15 years ago
|
Whiteboard: [nv]
Attachment #385241 -
Flags: review?(vladimir) → review+
Comment 2•15 years ago
|
||
Oops, looks like this got bitrotted by bug 487245. I think all that's needed now is changing the values of IDI_APPICON / IDI_DOCUMENT, there's now a nsWindowCE.h that contains the IDI_APPLICATION #define.
Assignee | ||
Comment 3•15 years ago
|
||
Carrying forward r+ - the changes to nsWindow.cpp are no longer needed
Attachment #385241 -
Attachment is obsolete: true
Attachment #387071 -
Flags: review+
Comment 4•15 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/8648c76c25ce
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Comment 5•15 years ago
|
||
Verified fix on branded build: Mozilla/5.0 (Windows; U; WindowsCE 6.0; en-US; rv:1.9.2a2pre) Gecko/20090811 Firefox/3.6a2pre. New FF icon there, in both the .exe and the WinCE toolbar (or whatever thats called).
You need to log in
before you can comment on or make changes to this bug.
Description
•