This is what we talked about today. If I go to the mailnews 3 pane and select all in the thread pane, when I click on another message, onselect is getting called for each message rather than when the removal of all of the selection is done. I put a dump statement in the onselect handler and it got called for each item in the tree.
reassigning to bryner to see if his recent changes have anything to do with it. also nominating for nsbeta3 and raising priority to p1.
Assignee: hyatt → bryner
Priority: P3 → P1
nsbeta3+, P3 for M18. added perf,regression keys, cc jrgm
Keywords: perf, regression
Priority: P1 → P3
Target Milestone: --- → M18
Status: NEW → ASSIGNED
OS: Windows NT → All
Hardware: PC → All
Ok, I know why this is happening. The click handler removes from the selection every item except the one that was just clicked. RemoveItemFromSelection fires the onselect handler. The only other way I see is to clear the selection and then reselect the item... which seems like it might be ugly visually. hyatt, RemoveItemFromSelectionInternal does *exactly* what I need here. What do you think about exposing this interface? Or do you know of a better way to do this?
hyatt and I are going to implement a suppressselect attribute on the tree to fix this.
-> xptoolkit (general tree issue)
Component: Mail Window Front End → XP Toolkit/Widgets: Trees
Product: MailNews → Browser
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
verified fixed: we only fire one onselect now, and performance for doing select all and then clicking a message is acceptable.
Status: RESOLVED → VERIFIED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: lchiang → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.