50058 - When removing selection after select all, onselect is called for each item.

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[scottputterman]

This is what we talked about today.  If I go to the mailnews 3 pane and select 
all in the thread pane, when I click on another message, onselect is getting 
called for each message rather than when the removal of all of the selection is 
done.  I put a dump statement in the onselect handler and it got called for each 
item in the tree.

Comment 1

[David Hyatt]

reassigning to bryner to see if his recent changes have anything to do with it.

also nominating for nsbeta3 and raising priority to p1.

Comment 2

[Peter Trudelle]

nsbeta3+,  P3 for M18. added perf,regression keys, cc jrgm

Comment 3

[Brian Ryner (not reading)]

Ok, I know why this is happening.  The click handler removes from the selection 
every item except the one that was just clicked.  RemoveItemFromSelection fires 
the onselect handler.  The only other way I see is to clear the selection and 
then reselect the item... which seems like it might be ugly visually.

hyatt, RemoveItemFromSelectionInternal does *exactly* what I need here.  What do 
you think about exposing this interface?  Or do you know of a better way to do 
this?

Comment 4

[Brian Ryner (not reading)]

hyatt and I are going to implement a suppressselect attribute on the tree to fix
this.

Comment 5

[Brian Ryner (not reading)]

-> xptoolkit (general tree issue)

Comment 6

[Brian Ryner (not reading)]

Fixed.

Comment 7

[Brian Ryner (not reading)]

verified fixed: we only fire one onselect now, and performance for doing select
all and then clicking a message is acceptable.