500590 - Window width & height limited to 999px

Status: RESOLVED INCOMPLETE

(Toolkit Graveyard :: XULRunner, defect)

Description

[Sudrien]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1) Gecko/20090616 Firefox/3.5 (.NET CLR 3.5.30729)
Build Identifier: b1

I tried to customize browser.jar to show a 1024x600 screen (for a UMPC). This resulted in only window decoration being rendered.

The cutoff seems to be at 999px. It affects both window width and height. 

Reproducible: Always

Steps to Reproduce:
In chrome\browser.jar:

<window id="main-window"
        onload="Browser.startup();"
        windowtype="navigator:browser"
        title="&brandShortName;"
        titlemodifier="&brandShortName;"
        titleseparator="&mainWindow.titleseparator;"
        width="1024"
        height="600"
        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
        xmlns:html="http://www.w3.org/1999/xhtml">
Actual Results:  
only window decoration being rendered

Expected Results:  
fill 1024x600 screen

Comment 1

[Ben Combee (:bcombee)]

I'm not sure where the 999/1000 limit comes from.  A simple grep for both of those numbers in the fennec doesn't show anything hard coded, as far as I can tell.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Proposed patch

If I do the same replacement as you, I have a browser width the sidebars badly placed and just after panning my UI is like dead.
With this patch all works perfectly for me.

If you have a screenshot to see the symptoms it can help.

In all cases, I supposed doing something like this could help users who want to customize the display width/height

Comment 3

[Sudrien]

Vivien: What build are you working off of? The paths in the patch are different than the win32 b1 build.

Patching the equivalent lines there gave the same decoration-only bar, just wide enough to hold the clack of icon, minimize, maximize, and close buttons. Interestingly, there was no window title. The browser area, when dragged wider (or maximized) is completely white.

Or: the same response as the over-999 issue.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #3)
> Vivien: What build are you working off of? The paths in the patch are different
> than the win32 b1 build.

I'm sync with the Fennec's trunk. It is a development environment

> 
> Patching the equivalent lines there gave the same decoration-only bar, just
> wide enough to hold the clack of icon, minimize, maximize, and close buttons.
> Interestingly, there was no window title. The browser area, when dragged wider
> (or maximized) is completely white.
> 
> Or: the same response as the over-999 issue.

Can you post a screenshot?

Comment 5

[Sudrien]

Attachment: Screenshot

Taken from windows 7 rc1 - same symptoms as xp

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Seems like your chrome is completely broken, can you launch Fennec in console using --jsconsole as an argument to see what's happen?

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Mark, can't we just localized these strings for people who want to put fennec on different devices that are considered as desktop for us?

This way people can just overrides the existing browser.dtd (or maybe an other one with just that?) to fit their needs.

Also I'm not sure we can override a dtd file by extension?

Comment 8

[Sudrien]

(In reply to comment #6)
> Seems like your chrome is completely broken, can you launch Fennec in console
> using --jsconsole as an argument to see what's happen?

No messages at all in jsconsole, with both 999px (working) or 1000px (broken) widths.

Comment 9

[Sudrien]

Win32 b2 build still has the issue, same lack of messages in jsconsole.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Sudrien, this should work with the b3 now since a lot of code has been changed.

Comment 11

[Sudrien]

b3, while doing a lot for resizing the window, still shows the same limitations for initial window#main-window width and height.

It's interesting that none of the xulrunner example apps I've looked through seem to be set above this size - perhaps its their issue?

Comment 12

[Aakash Desai [:aakashd]]

Vivien, is this a device related issue or something that we should be looking at again? If not, then we'll move this to a wontfix state. If yes, then let's push this along the queue.

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #12)
> Vivien, is this a device related issue or something that we should be looking
> at again? If not, then we'll move this to a wontfix state. If yes, then let's
> push this along the queue.

That's definitively not a blocker, and I suppose that's something related to the Windows version (can't reproduce on my Linux box).

But that's probably not a Fennec bug, sounds more like a toolkit bug.
Sudrien can you test a simple Xulrunner app with your bugging value? (I mean any Xulrunner app, except Fennec)

Comment 14

[Sudrien]

Found where I could make a similar edit in Prism - and got the same result.

Xulrunner bug it is, then.

Comment 15

[Benjamin Smedberg]

XULRunner has been removed from the Mozilla tree: see https://groups.google.com/forum/#!topic/mozilla.dev.platform/_rFMunG2Bgw for context.

I am closing all the bugs currently in the XULRunner bugzilla component, in preparation for moving this component to the graveyard. If this bug is still valid in a XULRunner-less world, it will need to be moved to a different bugzilla component to be reopened.