500612 - Scripts should run upon </script> even if script parent has been removed from the tree

Status: ASSIGNED

(Core :: DOM: HTML Parser, defect)

Description

[Henri Sivonen (:hsivonen)]

From bug 487949:
> >+  nsCOMPtr<nsIScriptElement> sele = do_QueryInterface(mScriptElement);
> >+ 
> >+   // Notify our document that we're loading this script.
> >+  nsCOMPtr<nsIHTMLDocument> htmlDocument = do_QueryInterface(mDocument);
> >+  NS_ASSERTION(htmlDocument, "Document didn't QI into HTML document.");
> >+  htmlDocument->ScriptLoading(sele);
> >+ 
> >+   // Copied from nsXMLContentSink
> >+  
> >+  // Now tell the script that it's ready to go. This may execute the script
> >+  // or return NS_ERROR_HTMLPARSER_BLOCK. Or neither if the script doesn't
> >+  // need executing.
> >+  nsresult rv = mScriptElement->DoneAddingChildren(PR_TRUE);
> 
> So per current HTML spec this doesn't do exactly the right thing. If a parent
> of the script element has been removed from the document, the script won't
> execute here. However the HTML spec says it should. There was a recent thread
> about this on the HTML list.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Remove script's IsInDoc() test

Patch not tested yet.

Comment 2

[Henri Sivonen (:hsivonen)]

The patch fails Mochitest. I suppose it needs to be conditional on html5.enable.