[HTML5] Recycle continue event objects

RESOLVED INVALID

Status

()

Core
HTML: Parser
RESOLVED INVALID
9 years ago
8 years ago

People

(Reporter: hsivonen, Unassigned)

Tracking

Other Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

From bug 487949:
> >+  // This creates a reference cycle between this and the event that is
> >+  // broken when the event fires.
> >+  nsCOMPtr<nsIRunnable> event = new nsHtml5ParserContinueEvent(this);
> >+  if (NS_FAILED(NS_DispatchToCurrentThread(event))) {
> >+      NS_WARNING("failed to dispatch parser continuation event");
> >+  } else {
> >+      mContinueEvent = event;
> >+  }
> 
> Probably worth keeping the event object around and reuse it multiple times.

(Need to deal with the reference cycle issues.)
The continue event is gone.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.