500652 - remember your password is missing the X on my HTC in landscape mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

On my HTC Touch Pro using a release candidate for alpha2 from 6/26 nightly, I am logging into litmus (in landscape mode) and it asks me if I want to remember my password.

There is a small bit of red to the right of the screen which appears to be the edge of the red X to close the message.

on my maemo build and desktop linux build of fennec the red x looks just fine.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

The windows theme (which is the base for the Fennec winmo theme) uses a -moz-image-rect in the notification close button style.

This patch handles the image rect and also cleans up the themes/Makefile.in, which was causing the "hildon" theme folder to be built even for Windows Mobile.

Comment 2

[Tony Chung [:tchung]]

I tested the windows desktop on windows 7, and the leftside of the "X" icon is clipped.   Interestingly, if you move the mouse over to the right side of the screen, it then clips the right edge of the X.

Screenshot: http://www.grabup.com/uploads/48713b0af0158e990079b5041c51d471.png

Comment 3

[Aakash Desai [:aakashd]]

I'm seeing the same thing as Tony.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/f743c56f9ef7

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090818 Fennec/1.0a3pre