Closed
Bug 500663
Opened 14 years ago
Closed 14 years ago
update product-details for Firefox 3.5
Categories
(www.mozilla.org :: General, defect)
www.mozilla.org
General
Tracking
(Not tracked)
RESOLVED
FIXED
3.5
People
(Reporter: Pike, Assigned: reed)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
69.04 KB,
patch
|
Details | Diff | Splinter Review |
We need to update the product and firefox details to kick out 2.0.0.x, and switch over that chunk to 3.0, get 3.5 to stable, and make sure that the right set of locales there are on the beta chunk. Pascal, stas, you guys have the list for beta, right?
Updated•14 years ago
|
Flags: blocking-firefox3.5?
Updated•14 years ago
|
Flags: blocking-firefox3.5? → blocking-firefox3.5+
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → reed
Comment 1•14 years ago
|
||
Beta locales shipped for the first time: bn-BD, es-CL, es-MX, kk, ml, or, rm, ta, ta-LK Locales with a non-beta 3.0.x release but that we ship as beta for 3.5: mn, tr Locale that stays as a beta on the 3.0.x branch but that is non-beta with 3.5: cy New locales that are shipped as normal non-beta 3.5 releases: as, fa, hr, vi
Comment 2•14 years ago
|
||
When do we need to make the change?
Comment 3•14 years ago
|
||
as soon as possible on trunk so as to test the downnload boxes, especially for beta locales.
Comment 4•14 years ago
|
||
Ok. So in product details we have two arrays - primary_builds and beta_builds plus three options per entry - LATEST_FIREFOX_OLDER_VERSION, LATEST_FIREFOX_OLDER_VERSION and LATEST_FIREFOX_VERSION. primary_builds, LATEST_FIREFOX_VERSION: as, fa, hr, vi, cy primary_builds, LATEST_FIREFOX_OLDER_VERSION: mn, tr beta_builds, LATEST_FIREFOX_DEVEL_VERSION: mn, tr beta builds, LATEST_FIREFOX_OLDER_VERSION: cy For beta_builds, LATEST_FIREFOX_DEVEL_VERSION: bn-BD, es-CL, es-MX, kk, ml, or, rm, ta, ta-LK Sound right?
Comment 5•14 years ago
|
||
the beta_builds are beta as in beta language, not beta product, so bn-BD, es-CL, es-MX, kk, ml, or, rm, ta, ta-LK should be as LATEST_FIREFOX_VERSION but in the beta_builds array
Comment 6•14 years ago
|
||
Ok.
Comment 7•14 years ago
|
||
I can't do this right now, but can do it when I get back later tonight -- Reed if you want to make the patch go for it; otherwise I'll do it tonight.
Assignee | ||
Comment 8•14 years ago
|
||
I'm working on this. I have a perl script that's almost done that will let me populate all the arrays with proper up-to-date file sizes for the build files. It's pretty late here, so I'm going to go to bed and finish it tomorrow afternoon. If tomorrow afternoon is too late, maybe somebody can just add the locales with bogus file sizes for now, and I'll fix it afterwards. We really need a better way of getting this information. :(
Status: NEW → ASSIGNED
Assignee | ||
Comment 9•14 years ago
|
||
... where "this information" is the file sizes and such, of course... hopefully, my script will be useful in the future for each new release.
Comment 10•14 years ago
|
||
Ok, let me know if I can help or not. Thanks, Reed.
Assignee | ||
Comment 11•14 years ago
|
||
This is what I landed... 'cy' isn't completely right, but I'll debug it later today when I can grab clouserw.
Assignee | ||
Comment 12•14 years ago
|
||
This should be good enough to start QA'ing. The problem with blank 'cy' lines on all.html and all-older.html is known, and I'll have that fixed later today.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 13•14 years ago
|
||
Dropping the LATEST_FIREFOX_DEVEL_VERSION is causing a PHP notice on the home page (not visible on trunk due to the php config): Notice: Use of undefined constant LATEST_FIREFOX_DEVEL_VERSION - assumed 'LATEST_FIREFOX_DEVEL_VERSION' in /so/sites/mozilla/mozilla-com-trunk/includes/product-details/productDetails.class.php on line 119
Comment 14•14 years ago
|
||
I am reopening as per steven's last comment. We should probably keep the defined constant as an empty string.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•14 years ago
|
Target Milestone: --- → 3.5
Comment 15•14 years ago
|
||
Uhm; this needs to be fixed before 6:30am PDT on Tuesday, June 30th. Status, please?
Assignee | ||
Comment 16•14 years ago
|
||
I hate product-details.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 17•14 years ago
|
||
Sorry, I have to reopen this. Currently, mn and tr both show up both as beta and non-beta for 3.5. I don't exactly understand the php magic of what we need to do to fix that. Would LATEST_FIREFOX_VERSION => array(/* still beta on 3.5 */), work?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 18•14 years ago
|
||
Forked the last issue into bug 501374 to resolve this release blocker.
Comment 19•13 years ago
|
||
if the work here is finished, could you please mark status1.9.1 accordingly? or fixed1.9.1 keyword at least. i'm querying bugzilla for unfinished 1.9.1 bugs and this is still marked as unfinished. or any other way to mark that we are done here, that i can query on.
Reporter | ||
Updated•13 years ago
|
Keywords: fixed1.9.1
Updated•11 years ago
|
Component: www.mozilla.org/firefox → www.mozilla.org
Updated•11 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•