500663 - update product-details for Firefox 3.5

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Axel Hecht [:Pike]]

We need to update the product and firefox details to kick out 2.0.0.x, and switch over that chunk to 3.0, get 3.5 to stable, and make sure that the right set of locales there are on the beta chunk.

Pascal, stas, you guys have the list for beta, right?

Comment 1

[Pascal Chevrel:pascalc]

Beta locales shipped for the first time:
bn-BD, es-CL, es-MX, kk, ml, or, rm, ta, ta-LK

Locales with a non-beta 3.0.x release but that we ship as beta for 3.5:
mn, tr

Locale that stays as a beta on the 3.0.x branch but that is non-beta with 3.5:
cy

New locales that are shipped as normal non-beta 3.5 releases:
as, fa, hr, vi

Comment 2

[Michael Morgan [:morgamic]]

When do we need to make the change?

Comment 3

[Pascal Chevrel:pascalc]

as soon as possible on trunk so as to test the downnload boxes, especially for beta locales.

Comment 4

[Michael Morgan [:morgamic]]

Ok. So in product details we have two arrays - primary_builds and beta_builds plus three options per entry - LATEST_FIREFOX_OLDER_VERSION, LATEST_FIREFOX_OLDER_VERSION and LATEST_FIREFOX_VERSION.

primary_builds, LATEST_FIREFOX_VERSION:
as, fa, hr, vi, cy

primary_builds, LATEST_FIREFOX_OLDER_VERSION:
mn, tr

beta_builds, LATEST_FIREFOX_DEVEL_VERSION:
mn, tr

beta builds, LATEST_FIREFOX_OLDER_VERSION:
cy

For beta_builds, LATEST_FIREFOX_DEVEL_VERSION:
bn-BD, es-CL, es-MX, kk, ml, or, rm, ta, ta-LK

Sound right?

Comment 5

[Pascal Chevrel:pascalc]

the beta_builds are beta as in beta language, not beta product, so bn-BD, es-CL, es-MX, kk, ml, or, rm, ta, ta-LK should be as LATEST_FIREFOX_VERSION but in the beta_builds array

Comment 6

[Michael Morgan [:morgamic]]

Ok.

Comment 7

[Michael Morgan [:morgamic]]

I can't do this right now, but can do it when I get back later tonight -- Reed if you want to make the patch go for it; otherwise I'll do it tonight.

Comment 8

[Reed Loden [:reed]]

I'm working on this. I have a perl script that's almost done that will let me populate all the arrays with proper up-to-date file sizes for the build files. It's pretty late here, so I'm going to go to bed and finish it tomorrow afternoon. If tomorrow afternoon is too late, maybe somebody can just add the locales with bogus file sizes for now, and I'll fix it afterwards.

We really need a better way of getting this information. :(

Comment 9

[Reed Loden [:reed]]

... where "this information" is the file sizes and such, of course... hopefully, my script will be useful in the future for each new release.

Comment 10

[Michael Morgan [:morgamic]]

Ok, let me know if I can help or not. Thanks, Reed.

Comment 11

[Reed Loden [:reed]]

Attachment: what I landed

This is what I landed... 'cy' isn't completely right, but I'll debug it later today when I can grab clouserw.

Comment 12

[Reed Loden [:reed]]

This should be good enough to start QA'ing. The problem with blank 'cy' lines on all.html and all-older.html is known, and I'll have that fixed later today.

Comment 13

[Steven Garrity [:sgarrity]]

Dropping the LATEST_FIREFOX_DEVEL_VERSION is causing a PHP notice on the home page (not visible on trunk due to the php config):


Notice: Use of undefined constant LATEST_FIREFOX_DEVEL_VERSION - assumed 'LATEST_FIREFOX_DEVEL_VERSION' in /so/sites/mozilla/mozilla-com-trunk/includes/product-details/productDetails.class.php on line 119

Comment 14

[Pascal Chevrel:pascalc]

I am reopening as per steven's last comment. We should probably keep the defined constant as an empty string.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Uhm; this needs to be fixed before 6:30am PDT on Tuesday, June 30th. Status, please?

Comment 16

[Reed Loden [:reed]]

I hate product-details.

Comment 17

[Axel Hecht [:Pike]]

Sorry, I have to reopen this.

Currently, mn and tr both show up both as beta and non-beta for 3.5. I don't exactly understand the php magic of what we need to do to fix that. Would

LATEST_FIREFOX_VERSION => array(/* still beta on 3.5 */), 

work?

Comment 18

[Axel Hecht [:Pike]]

Forked the last issue into bug 501374 to resolve this release blocker.

Comment 19

[Marco Bonardo [:mak]]

if the work here is finished, could you please mark status1.9.1 accordingly? or fixed1.9.1 keyword at least. i'm querying bugzilla for unfinished 1.9.1 bugs and this is still marked as unfinished. or any other way to mark that we are done here, that i can query on.