500678 - Manage text off-center in Bookmarks Manager

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Aakash Desai [:aakashd]]

Attachment: Manage button Screenshot

Build Id: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090626 Fennec/1.0b2

The text on the Manage button, "Manage", is off-center to the right side. THis should be centered more to the left a bit.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

verified on winmo and maemo builds as well.

Comment 2

[Tony Chung [:tchung]]

In addition to the manage button, without bookmarks, it would be great if the shade of the manage button would toggle if its on or off.  Currently, it's the same color to the user, and not clearly define the state its in.

manage off: http://www.grabup.com/uploads/5321b07456ea20c131182beac0466fd8.png
manage on: http://www.grabup.com/uploads/3608a1b737e57ab7fde006d6193521a2.png

Comment 3

[Aakash Desai [:aakashd]]

That sounds like another bug, Tony :)

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.1

Change the moz-margin-end to 0 if there is no image on the toolbarbutton

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed: https://hg.mozilla.org/mobile-browser/rev/5ca8845e76b7

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20091002
Fennec/1.0b4

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/200910002
Fennec/1.0b4