500750 - mDBConn is not set to NULL in release builds

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Because we have a non-braced if statement for an NS_ERROR statement, mDBConn is not set to NULL in release builds.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 385437 [details] [diff] [review]
v1.0

>diff --git a/storage/src/mozStorageConnection.cpp b/storage/src/mozStorageConnection.cpp
>   int srv = ::sqlite3_close(mDBConn);
>-  if (srv != SQLITE_OK)
>-    NS_ERROR("sqlite3_close failed. There are probably outstanding statements that are listed above!");
>+  NS_ASSERTION(src == SQLITE_OK,
                   ^

c != v

r=asuth with that fixed.

Comment 2

[Shawn Wilsher :sdwilsh]

Whoops - had a build going so I couldn't test-compile.

Comment 3

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/37fd13fb79cf