500767 - Get rid of SIP button on windows mobile

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

The SIP button is way to ugly because we don't have softkeys.  Madhava decided we should get rid of it and just loose the functionality.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: Always call ShowWindow(hWndSIP, SW_HIDE)

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 385443 [details] [diff] [review]
Always call ShowWindow(hWndSIP, SW_HIDE)

I do not think I understand this.

when I click in a text box, a software keyboard provided by a 3rd party or MS appears.  What this patch does is just makes it impossible to switch between these keyboards.

how about we:

1) make this a pref so that power users could rename it
2) reposition the keyboard so that it takes up the space where the SIP button was (eg. move the keyboard window down by the height of the SIP button.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.2

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

In an effort to be consistent with existing prefs, could you use:

ui.showSIPButton

If we think we will have more SIP (windows, maemo or other platforms) we could use:

ui.sip.showButton

where we could use "sip" (software input panel) to mean "software keyboard"

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 386204 [details] [diff] [review]
patch v.2

create a static variable that gets set instead of checking for the pref every time we activate (similar to what we do for painting -- see  sRenderMode)

what finkle said too.

what is the behavior if hWndSIPB or hWndSIP are null and you make it into the block where "showSIPButton != PR_TRUE"?  Maybe we should just return early if either are null?

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.3

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.4

fixed logic

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/2c4c63849e9f