500821 - Sidebar showing/syncing code need a clean up

Status: VERIFIED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.1

Sidebars showing/syncing code currently live in browser-ui.js, browser.js and InputHandler.js and methods to show/hide them begin to hatch (hideTabs/hideControls).

In order to maintain the RTL support we need methods that doesn't assume controls is right and tabs is left

I put this one blocking bug 476423 for that.

Comment 1

[Ben Combee (:bcombee)]

Beware -- the sidebar code is about to be changed a bit by stuart to deal with a new tilecache version of canvas browser.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The tilecache has completely reformat the way we handle sidebars.

Comment 3

[Biju]

sorry for bug spam.
Many of the bugs which are marked invalid, I see comments telling it occurred in one version or other. But later it was fixed due to 1) by backingout the patch which made regression or 2) by fixing some other bug.
So if we can identify the bug/patch/reason then we should state that and mark those as FIXED. If not mark as WORKSFORME in that case.