500857 - TM: TraceVis: show jit-flush events on visualization

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

It turns out that it can be very useful to show markers on the visualization for calls to js_FlushJITCache. This is already in my personal TraceVis repo. I just need to get the commit fixed for the bug 496448 patch and turn my personal repo changesets into a patch for TM.

Comment 1

[David Mandelin [:dmandelin]]

Attachment: Patch

Here is the patch. It also incorporates a bug fix or two from Leandro Lameiro and perf improvements to the Python logfile processing (a straight backport from the C++ version). I would have filed two patches but it wasn't easy to separate them in the dev sequence and I figure it's not a huge deal for an ancillary program like this one.

Comment 2

[Nicholas Nethercote [inactive]]

Dave, I totally dropped the ball on this review -- I somehow overlooked it and didn't realise it was pending.  Do you still need it reviewed?  Is the patch still up to date?  If so, let me know and I'll do it ASAP.

Comment 3

[David Mandelin [:dmandelin]]

Attachment: Patch 2 (rebased)

No problem. Here is it, rebased to tip.

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 399840 [details] [diff] [review]
Patch 2 (rebased)

The C++ parts look fine.  The Python parts also look ok, but I'm barely literate in Python so you might like to get someone else to check them.  But the Python parts are an auxiliary program, so I'm also happy if you don't want to do that.

Comment 5

[David Mandelin [:dmandelin]]

Thanks. I'm not too worried about the Python part.

Pushed to TM as 330f51a75fcd.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/330f51a75fcd

Comment 7

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/57b01ded4e5e