500916 - Access key conflict in menu "Events and Tasks"

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning 1.0pre (BuildID: 20090627031549)

Access key conflict in menu "Events and Tasks": Access key "T" is used for both "New Task..." and "Tasks".

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

Unfortunate, but since we are in string freeze, I think its ok to postpone this to after the beta.

Comment 2

[Matthew Mecca [:mmecca]]

Attachment: [short,l10n] Proposed Patch

Changes access key for "New Task..." to "K" to resolve conflict in menu and to make consistent with access key in context menu.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 396066 [details] [diff] [review]
[short,l10n] Proposed Patch

For the automated l10n tools to notice the string change, the entity name needs to be changed.

I'd suggest changing the entity names to

event.new.task
event.new.task.key
event.new.task.accesskey

and changing all files using these respectively. Please upload a new patch when you are done.

Comment 4

[Matthew Mecca [:mmecca]]

Attachment: Patch v2

Changes entity names.

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 454388 [details] [diff] [review]
Patch v2

>-<!ENTITY event.new.todo                         "New Taskâ¦">
>-<!ENTITY event.new.todo.key                     "T">
>-<!ENTITY event.new.todo.accesskey               "T">
>+<!ENTITY event.new.task                         "New Taskâ¦">
>+<!ENTITY event.new.task.key                     "K">
>+<!ENTITY event.new.task.accesskey               "K">
Looks like your editor/diff engine is not UTF-8 aware. Please fix for future patches
Also, the accesskey needs to match the case (i.e k instead of K), otherwise it will say "New Task (_K_)"



r=philipp with this fixed.
I've fixed this locally and will check in that patch for you.

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/3af9425f8752>
-> FIXED

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/cf8f82245905>

a=philipp