Access key conflict in menu "Events and Tasks"

RESOLVED FIXED in 1.0b3

Status

defect
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: ssitter, Assigned: mmecca)

Tracking

Trunk
1.0b3
Bug Flags:
blocking-calendar1.0 +

Details

(Whiteboard: [needed beta][has l10n impact])

Attachments

(1 attachment, 1 obsolete attachment)

Lightning 1.0pre (BuildID: 20090627031549)

Access key conflict in menu "Events and Tasks": Access key "T" is used for both "New Task..." and "Tasks".
Unfortunate, but since we are in string freeze, I think its ok to postpone this to after the beta.
Flags: blocking-calendar1.0+
Whiteboard: [not needed beta][has l10n impact]
Assignee: nobody → matthew.mecca
Posted patch [short,l10n] Proposed Patch (obsolete) — Splinter Review
Changes access key for "New Task..." to "K" to resolve conflict in menu and to make consistent with access key in context menu.
Attachment #396066 - Flags: review?(philipp)
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: x86 → All
Attachment #396066 - Attachment description: [after beta] Proposed Patch → [short,l10n] Proposed Patch
Comment on attachment 396066 [details] [diff] [review]
[short,l10n] Proposed Patch

For the automated l10n tools to notice the string change, the entity name needs to be changed.

I'd suggest changing the entity names to

event.new.task
event.new.task.key
event.new.task.accesskey

and changing all files using these respectively. Please upload a new patch when you are done.
Attachment #396066 - Flags: review?(philipp) → review-
Posted patch Patch v2Splinter Review
Changes entity names.
Attachment #454388 - Flags: review?(philipp)
Attachment #396066 - Attachment is obsolete: true
Comment on attachment 454388 [details] [diff] [review]
Patch v2

>-<!ENTITY event.new.todo                         "New Task…">
>-<!ENTITY event.new.todo.key                     "T">
>-<!ENTITY event.new.todo.accesskey               "T">
>+<!ENTITY event.new.task                         "New Task…">
>+<!ENTITY event.new.task.key                     "K">
>+<!ENTITY event.new.task.accesskey               "K">
Looks like your editor/diff engine is not UTF-8 aware. Please fix for future patches
Also, the accesskey needs to match the case (i.e k instead of K), otherwise it will say "New Task (_K_)"



r=philipp with this fixed.
I've fixed this locally and will check in that patch for you.
Attachment #454388 - Flags: review?(philipp) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/3af9425f8752>
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0b3
Whiteboard: [not needed beta][has l10n impact] → [needed beta][has l10n impact]
You need to log in before you can comment on or make changes to this bug.