PlacesController.prototype._shouldShowMenuItem should not depend on bug 232598

RESOLVED FIXED in Firefox 3.6a1

Status

()

Firefox
Bookmarks & History
--
trivial
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 3.6a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
This line should test whether forcehideselection exists first:

var forceHideRules = aMenuItem.getAttribute("forcehideselection").split("|");
(Assignee)

Comment 1

9 years ago
Created attachment 385621 [details] [diff] [review]
patch
Attachment #385621 - Flags: review?(mak77)

Updated

9 years ago
Attachment #385621 - Flags: review?(mak77) → review+
Comment on attachment 385621 [details] [diff] [review]
patch

r=sdwilsh
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/mozilla-central/rev/48161673b084
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.