nsLayoutUtils.* fails to compile with --disable-ogg/wave

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

({regression})

Trunk
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

9 years ago
I have these two lines in .mozconfig:
ac_add_options --disable-ogg
ac_add_options --disable-wave

This tree does not compile anymore, it did work just a few days ago.
I suspect this is a regression from bug 492724.

Patch coming up...
(Assignee)

Comment 1

9 years ago
Created attachment 385633 [details] [diff] [review]
Patch rev. 1

The definition of nsIPrincipal is needed for a member of
'struct SurfaceFromElementResult' later in nsLayoutUtils.h
Attachment #385633 - Flags: review?(roc)
Would just a forward declaration of |class nsIPrincipal| be sufficient?
(Assignee)

Comment 3

9 years ago
Created attachment 385647 [details] [diff] [review]
Patch rev. 2

Not really, consumers of nsLayoutUtils::SurfaceFromElement() would have
to know that SurfaceFromElementResult is incomplete and include
nsIPrincipal.h themselves.

I did find some unnecessary #includes in CanvasUtils.h though.
(Assignee)

Comment 4

9 years ago
Created attachment 385648 [details] [diff] [review]
Patch rev. 3

rev. 1 with #includes cleaned up in CanvasUtils.h
Attachment #385633 - Attachment is obsolete: true
Attachment #385648 - Flags: review?(roc)
Attachment #385633 - Flags: review?(roc)
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/mozilla-central/rev/aed9be2e4602
http://hg.mozilla.org/mozilla-central/rev/0e868bb2de70

-> FIXED
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.