501049 - Inconsistent layout of <fieldset> with text-indent when emptying a text node

Status: RESOLVED WORKSFORME

(Core :: Layout: Block and Inline, defect)

Description

[Jesse Ruderman]

Attachment: testcase (dynamic)

Based on layout/forms/crashtests/266225-1.html

Comment 1

[Jesse Ruderman]

Attachment: reference (static)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Not form-related; you can get the same effect with a float:left div with a border on it.

We include the text-indent in the min-width of a shrink-wrap block if it has at least one line box.  The one in the dynamic case does (holding a single textframe).  The one in the static testcase does not.

Arguably, we shouldn't include the text-indent if there's no text... or something.

Comment 3

[Boris Zbarsky [:bzbarsky]]

It's odd that when we recreate the frame here from inside CharacterDataChanged we don't end up suppressing it.  roc, any idea why?  Not that we should be relying on the block whitespace suppression for correctness, but in this case it should be working for us that way.... ;)

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That would be because we never suppress a text frame created via ContentInserted, right?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Oh, right.  We don't set the item list as having line boundaries at start or end in ContentInserted.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Perhaps we should include the text-indent even if we have no line-boxes?

Comment 7

[Jesse Ruderman]

WFM