Closed
Bug 501117
Opened 15 years ago
Closed 15 years ago
Drop redundant IMAP strings from imapMsgs.properties
Categories
(MailNews Core :: Networking: IMAP, defect)
MailNews Core
Networking: IMAP
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
8.78 KB,
patch
|
neil
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
I've just been doing some work near the IMAP string and found 10 redundant string definitions and a further 2 redundant #defines. We should drop them as it is just unnecessary work for localisers. Some links for the interested: http://mxr.mozilla.org/comm-central/search?string=IMAP_STATUS_GETTING_NAMESPACE http://mxr.mozilla.org/comm-central/search?string=IMAP_UPGRADE_NO_PERSONAL_NAMESPACE http://mxr.mozilla.org/comm-central/search?string=IMAP_UPGRADE_PROMPT_USER_2 http://mxr.mozilla.org/comm-central/search?string=IMAP_UPGRADE_CUSTOM http://mxr.mozilla.org/comm-central/search?string=IMAP_UPGRADE_SUCCESSFUL http://mxr.mozilla.org/comm-central/search?string=IMAP_UNABLE_TO_SAVE_MESSAGE http://mxr.mozilla.org/comm-central/search?string=IMAP_NO_ONLINE_FOLDER http://mxr.mozilla.org/comm-central/search?string=IMAP_SELECTING_MAILBOX http://mxr.mozilla.org/comm-central/search?string=IMAP_HTML_NO_CACHED_BODY_TITLE http://mxr.mozilla.org/comm-central/search?string=IMAP_HTML_NO_CACHED_BODY_BODY http://mxr.mozilla.org/comm-central/search?string=IMAP_UNKNOWN_USER http://mxr.mozilla.org/comm-central/search?string=IMAP_REDIRECT_LOGIN_FAILED
Attachment #385742 -
Flags: superreview?(bienvenu)
Attachment #385742 -
Flags: review?(neil)
Updated•15 years ago
|
Attachment #385742 -
Flags: superreview?(bienvenu) → superreview+
Comment 1•15 years ago
|
||
Comment on attachment 385742 [details] [diff] [review] The fix there was a one time upgrade from Netscape 4.0-> 4.5, when we switched to using imap subscription, which accounts for some of those...
Comment 2•15 years ago
|
||
Comment on attachment 385742 [details] [diff] [review] The fix >-## @name IMAP_GETTING_ACL_FOR_FOLDER >+## @name IMAP_GETTING_ACL_FOR_FOLDER I don't think this was intentional ;-)
Attachment #385742 -
Flags: review?(neil) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Checked in with comment addressed: http://hg.mozilla.org/comm-central/rev/b3ce4abfb0f9
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•