Created attachment 385780 [details] comma steps to reproduce: 1.Log in to your AMO account. 2.Navigate to any add-on page 3.Click on "Add a atg" link 4.Enter "test,blah," as tags and click add expected result: the redundant trailing comma is ignored actual result: Comma is also saved(see attached image)
I had the idea that we should whack this along with trim()ing the tags, but making a special case for commas over other punctuation seems lame. ->wontfix
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WONTFIX
we're delimiting on commas ->reopen
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
This is already fixed, right?
(In reply to comment #3) > This is already fixed, right? Looks like this bug has turned into "trailing comma adds a blank tag" - for the record, a tag should never be blank. Just make the split function remove anything that is blank.
Created attachment 386675 [details] [diff] [review] fix ignore empty spaces. so the following: ,aaa, ,bbb, ,,,cccc, will only create tags: aaa bbb ccc
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago → 9 years ago
Resolution: --- → FIXED
A similar patch is committed in r29326
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.