501162 - Comma-separated tags are saved as single tag

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1.Log in to your AMO account
2.Navigate to any add-on's detail page
3.Click on "add a tag" link
4.Enter -test1,test2,test3.test4,test5,test6,test7,test8 and click add

expected result:
each comma separated tag is saved as a different tag

actual result:
test1,test2,test3.test4,test5,test6,test7,test8 is saved as a single tag

Comment 1

[Wil Clouser [:clouserw]]

Tags are space separated, not commas. :-/  I filed a separate bug to put an example next to the add box.

Comment 2

[krupa raj[:krupa]]

Wil,as per the specs,tags are comma delimited.

screenshot of spec :http://screencast.com/t/DGGmNymwI1A

Either its a bug in the spec or in implementation.Please provide further clarification.Thanks.

reopening...

Comment 3

[Wil Clouser [:clouserw]]

You are right, as usual. :)  /me is a fan of space separated tags

Comment 4

[Patrick Sullivan]

No problem to delimit tags on commas outside of quotes as well as spaces. I defer to Wil.

Comment 5

[Wil Clouser [:clouserw]]

Delimit on commas, let's follow the spec.  I don't know why we're requiring quotes then, but let's stick with it for now.

Comment 6

[Patrick Sullivan]

Attachment: Splits tags on commas instead of with spaces and quotes.

Comment 7

[Wil Clouser [:clouserw]]

using $_REQUEST here just plain won't work (they aren't passed in like that) and it also defeats the purpose of CSRF.  Please use $_POST - and it's probably best to keep that in the other bug anyway.

As far as the patch to split on commas, won't that split on commas between quotes too?

"Brooklyn Bridge", "New York, NY", bridge

^^ That should be 3 tags.  split()ing on a comma will make it 4.

Comment 8

[Patrick Sullivan]

Attachment: Changes the delimiter to a comma, preserving commas in quotes

Comment 9

[Wil Clouser [:clouserw]]

r29256, thanks!

Comment 10

[krupa raj[:krupa]]

looks fixed.