Fatal PHP error on editor performance charts

VERIFIED FIXED in 5.0.7

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
--
critical
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: mccammos, Assigned: mccammos)

Tracking

unspecified
5.0.7

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
This appears to be a regression from the merge with Webmocha tagging.

Notice: Undefined property: EditorsController::$Tag in /home/smccammon/public_html/communication-fix2-495491/site/app/controllers/editors_controller.php on line 850

Fatal error: Call to a member function unbindFully() on a non-object in /home/smccammon/public_html/communication-fix2-495491/site/app/controllers/editors_controller.php on line 850
(Assignee)

Comment 1

9 years ago
Created attachment 385788 [details] [diff] [review]
Fix

Updated all references to the old Tags table/model to Categories in the editors controller.
Assignee: nobody → smccammon
Status: NEW → ASSIGNED
Attachment #385788 - Flags: review?(clouserw)
Comment on attachment 385788 [details] [diff] [review]
Fix

thanks
Attachment #385788 - Flags: review?(clouserw) → review+
(Assignee)

Comment 3

9 years ago
fix in r28908
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: push-needed
Resolution: --- → FIXED
https://preview.addons.mozilla.org/en-US/editors is a 404; does some SQL need to be run on preview to fix this?

Comment 5

9 years ago
Fine for me ( https://preview.addons.mozilla.org/en-US/firefox/users/login?to=en-US%2Feditors )
Keywords: push-needed
(In reply to comment #5)
> Fine for me (
> https://preview.addons.mozilla.org/en-US/firefox/users/login?to=en-US%2Feditors
> )

Yeah, it was fixed by some Cake model cache or SQL run, or something.

Rey, can you verify on https://addons.mozilla.org/en-US/editors/performance?  Thanks!

Comment 7

9 years ago
Works perfectly. :)

Updated

9 years ago
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.